New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a setting to force image output format #360
Conversation
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 87.41% 87.41%
=======================================
Files 18 18
Lines 1438 1438
=======================================
Hits 1257 1257
Misses 181 181
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
==========================================
+ Coverage 87.42% 87.49% +0.06%
==========================================
Files 19 19
Lines 1503 1503
==========================================
+ Hits 1314 1315 +1
+ Misses 189 188 -1
Continue to review full report at Codecov.
|
(WORK IN PROGRESS) |
@@ -40,6 +40,9 @@ | |||
# Size of resized image (default: (640, 480)) | |||
img_size = (800, 600) | |||
|
|||
# Output format of images (default: None, i.e. use input format) | |||
img_format = "JPEG" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be commented as this file is meant to be used with the default values when creating a new gallery. Could you also add in the comment a list of possible values for the most common formats (e.g. png) ?
Thanks, this can indeed be useful. If you can address my comment then I think it is good to go ? |
Thanks! |
Add a setting to force image output format
It seems that sigal uses the format of input images for each output image. This new setting allows one to hard-code the output format of all images in the settings.conf.py.
My use case: I develop images to tiffs, and many browsers dont' like tiffs it seems. Now I can force JPEG output for all images, and browsers are happy to display them.
Thanks,
Kevin