Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use natural sorting #387

Merged
merged 1 commit into from Apr 14, 2020
Merged

Use natural sorting #387

merged 1 commit into from Apr 14, 2020

Conversation

dbw9580
Copy link
Contributor

@dbw9580 dbw9580 commented Apr 11, 2020

This PR uses natsort to replace locale.strxfrm to make sorting numbers in filenames and album names more human-friendly. natsort still handles locale-specific sorting through its internal use of locale.

This will add a new dependency on natsort.

@codecov
Copy link

@codecov codecov bot commented Apr 11, 2020

Codecov Report

Merging #387 into master will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   87.49%   87.40%   -0.10%     
==========================================
  Files          19       19              
  Lines        1503     1524      +21     
==========================================
+ Hits         1315     1332      +17     
- Misses        188      192       +4     
Impacted Files Coverage Δ
sigal/gallery.py 90.66% <100.00%> (+0.86%) ⬆️
sigal/image.py 89.40% <0.00%> (-2.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 972f0f1...8143e2a. Read the comment docs.

@saimn saimn added this to the 2.1 milestone Apr 14, 2020
@saimn
Copy link
Owner

@saimn saimn commented Apr 14, 2020

Seems sensible, thanks @dbw9580.

@saimn saimn merged commit ee7a719 into saimn:master Apr 14, 2020
1 of 2 checks passed
@dbw9580 dbw9580 deleted the natural_sort branch Apr 20, 2020
kontza pushed a commit to kontza/sigal that referenced this issue Aug 28, 2020
@saimn saimn mentioned this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants