Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow video_size = None in settings.py #435

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

dsschult
Copy link
Contributor

A small fix to allow video_size = None, which is the way to disable video resizing.

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #435 (126fce5) into main (7ba5f7b) will increase coverage by 0.04%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   86.48%   86.53%   +0.04%     
==========================================
  Files          22       22              
  Lines        1828     1834       +6     
==========================================
+ Hits         1581     1587       +6     
  Misses        247      247              
Impacted Files Coverage Δ
sigal/gallery.py 89.44% <87.50%> (-0.10%) ⬇️
sigal/settings.py 97.91% <100.00%> (+0.04%) ⬆️
sigal/image.py 91.66% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b80297...126fce5. Read the comment docs.

@saimn saimn added this to the 2.3 milestone Jun 29, 2021
@saimn saimn merged commit 69450d0 into saimn:main Jun 29, 2021
@saimn
Copy link
Owner

saimn commented Jun 29, 2021

Thanks!

@dsschult dsschult deleted the fix_video_size_check branch July 6, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants