Skip to content
This repository has been archived by the owner on Oct 3, 2021. It is now read-only.

Changed next button to submit button on the last step #14

Merged

Conversation

DimK10
Copy link
Contributor

@DimK10 DimK10 commented Sep 3, 2020

When a form is used with this component, there must be an onSubmit function on the last step, to handle all the form data and to make a request to an api, so i added this functionality.

…nSubmit prop which is a function. Also, added the flexibility for the user to change the text in the submit button.
@saini-g
Copy link
Owner

saini-g commented Sep 4, 2020

@DimK10 there is a conflict in the code, please resolve it and then I will merge

@DimK10
Copy link
Contributor Author

DimK10 commented Sep 4, 2020

I have resolved all the conflicts, so it's good to go. Please, if possible, make the necessary actions so that i can use the updated code in the npm (in order to use the code with the commit that fixed the stroke-width error, i needed to npm i https://github.com/saini-g/react-step-progress.git to get the code directly from master, the npm i
react-step-progress is not updated). And, if you want, i could change the readme for the documentation with the changes applied. Also, thanks!

@saini-g
Copy link
Owner

saini-g commented Sep 4, 2020

@DimK10
Really glad you like the component.

i could change the readme for the documentation with the changes applied.

That would be awesome. I can get the new release on npm easily over the weekend.

@DimK10
Copy link
Contributor Author

DimK10 commented Sep 4, 2020

Cool! I'll make another commit with the readme changes for the documentation! Feel free to contact me in dimk10@hotmail.com
if you would like me to contribute to an issue!

@DimK10
Copy link
Contributor Author

DimK10 commented Sep 4, 2020

The branch is ready to merge! I also made the necessary fixes in the readme.md file.

@saini-g saini-g merged commit aefb5e5 into saini-g:master Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants