Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last parameter of load_pnm has pointer vs. non-pointer conflict #40

Closed
tautschnig opened this issue Mar 6, 2015 · 2 comments
Closed

Last parameter of load_pnm has pointer vs. non-pointer conflict #40

tautschnig opened this issue Mar 6, 2015 · 2 comments
Assignees
@saitoha
Labels
bug

Comments

@tautschnig
Copy link

Hello,

While compiling libsixel using our tool chain we noticed that the last parameter of load_pnm has inconsistent declarations:

https://github.com/saitoha/libsixel/blob/master/converters/frompnm.h#L37
vs.
https://github.com/saitoha/libsixel/blob/master/converters/frompnm.c#L58

It seems that (luckily) this parameter isn't being used at present, but whenever it is, this will severe security implications.

Best,
Michael
saitoha added a commit that referenced this issue Mar 7, 2015
@saitoha
Resolve confliction of parameter declarations of load_pnm(), reported…
0622f04 
… by @tautschnig. (for Issue #40)
@saitoha
Copy link
Owner

saitoha commented Mar 7, 2015

@tautschnig Thanks! This fix will be included in the v1.4.10 release of libsixel.

@saitoha
Copy link
Owner

saitoha commented Mar 9, 2015

Merged. Thanks!

@saitoha saitoha closed this as completed Mar 9, 2015
@saitoha saitoha added the bug label Mar 9, 2015
@saitoha saitoha self-assigned this Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saitoha saitoha

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tautschnig @saitoha