Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-40943 Always include current user memberships #6256

Merged
merged 1 commit into from Nov 17, 2018

Conversation

buckett
Copy link
Member

@buckett buckett commented Nov 16, 2018

When getting memberships for the current user the list of sites to return the results for were incorrectly getting filtered so that only the entries where the current user was allowed to view the roster in the site. That should have only been happening when the a non-admin user was looking for the memberships of a different user.

When getting memberships for the current user the list of sites to return the results for were incorrectly getting filtered so that only the entries where the current user was allowed to view the roster in the site. That should have only been happening when the a non-admin user was looking for the memberships of a different user.
@mpellicer
Copy link
Contributor

Happy to see you here @buckett !

Copy link
Contributor

@ottenhoff ottenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ottenhoff ottenhoff merged commit fff82e9 into sakaiproject:master Nov 17, 2018
ottenhoff pushed a commit that referenced this pull request Nov 21, 2018
When getting memberships for the current user the list of sites to return the results for were incorrectly getting filtered so that only the entries where the current user was allowed to view the roster in the site. That should have only been happening when the a non-admin user was looking for the memberships of a different user.

(cherry picked from commit fff82e9)
ern pushed a commit that referenced this pull request Nov 21, 2018
When getting memberships for the current user the list of sites to return the results for were incorrectly getting filtered so that only the entries where the current user was allowed to view the roster in the site. That should have only been happening when the a non-admin user was looking for the memberships of a different user.

(cherry picked from commit fff82e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants