Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-41763: XSS in chat user name - 12.x #6971

Merged
merged 1 commit into from Jun 4, 2019

Conversation

hornersa
Copy link
Contributor

For this fix to be applied to 12.x, I needed to add some runtime libraries and upgrade taglibs from 1.0.4. I chose 1.1.2 because this is the version already used by the site/admin-prefs tool in 12.x.

chat/chat-tool/tool/pom.xml Outdated Show resolved Hide resolved
@mpellicer mpellicer merged commit 57dc8c9 into sakaiproject:12.x Jun 4, 2019
@mpellicer
Copy link
Contributor

Thank you so much @hornersa

@@ -42,7 +42,7 @@
<c:out value="<span class='chatUserOnline'></span>" escapeXml="false" />
<c:out value="</span>" escapeXml="false" />

<c:out value="<span class='chatNameDate'><span class='chatName'>${message.owner}</span>" escapeXml="false" />
<c:out value="<span class='chatNameDate'><span class='chatName'>${fn:escapeXml(message.owner)}</span>" escapeXml="false" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with this templating language, but it seems to me this should be written as follows:

<span class='chatNameDate'><span class='chatName'><c:out value="${message.owner}"></span>

marktriggs pushed a commit to NYUeServ/sakai11 that referenced this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants