SAK-44702 Long img alt text with linebreaks can cause StackOverflowError #8832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paragraph regexp is too complex for long img alt text which includes linebreaks. This uses a simpler regexp for alt text.
adrianfish
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
I'm happy with this going in and then getting a bit of testing. It does seem like overkill applying the paragraph regexp to a simple alt text. Alt texts can't be supplied by the user, so the risk is a lot lower than what I guess is the target of the paragraph regexp.
bjones86
pushed a commit
to Western-OWL/sakai
that referenced
this pull request
Oct 15, 2021
…use StackOverflowError (sakaiproject#8832) The paragraph regexp is too complex for long img alt text which includes linebreaks. This uses a simpler regexp for alt text. (cherry picked from commit c798cf8) (cherry picked from commit d7f43d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paragraph regexp is too complex for long img alt text which includes linebreaks. This uses a simpler regexp for alt text.
However, I'm not totally sure whether it's ok to simplify to this extent and this should be reviewed to see if there's anything that actually should not be permitted in alt text, in which case an intermediate regexp may be required that's simpler than paragraph but more complex than anyWithPara.