Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD_HOST and VLAN #3

Merged
merged 3 commits into from Dec 22, 2018

Conversation

Projects
None yet
2 participants
@burnbabyburn
Copy link
Contributor

commented Dec 19, 2018

No description provided.

@burnbabyburn burnbabyburn referenced this pull request Dec 19, 2018

Open

SD_HOST Drivers #2

@sakaki-

This comment has been minimized.

Copy link
Owner

commented Dec 20, 2018

Looks good. Three points:

  1. please make all comment lines have a single space after the # for uniformity;
  2. please place your new section at the end of the conform_config.txt file; and
  3. your sed line targets "${KERNEL_DIR}"/drivers/mmc/host/Kconfig; that won't work for my autobuild system. If you use ${KERNEL_DIR:-.} instead, that'll set the path to ./drivers/mmc/host/Kconfig if KERNEL_DIR is unset or empty, which will work if the script is run in the kernel source root directory, for an in-tree build (and still will allow override in other contexts where the var is defined).

With those changes I should be good to merge this.

@burnbabyburn

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

Thx for your input. Since conform_config.sh already assumes you're in KERNEL_DIR, (point 3) could be dropped completly.

Update conform_config.sh
omit KERNEL_DIR var
@sakaki-

This comment has been minimized.

Copy link
Owner

commented Dec 22, 2018

OK thanks, will merge now.
Best, sakaki

@sakaki- sakaki- merged commit 3e47ab5 into sakaki-:master Dec 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.