-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for grouped menus #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setGroupVisible currently hides the group but does not adjust the menu height.
Can you explain more? Why does the popup height change?
Adding support for setGroupCheckable
Let's leave this for now
setGroupEnabled is functional but the group state stays the same. (Perhaps we could add color states for disabled items)
What does PopupMenu
do here?
This was the same bug as #12, which we resolved in #13.
Sounds good.
This looks more of an enhancement for styles in Setting any item disabled keeps it the same visually. So perhaps we just need to add |
@saket do you realize the glitch in title change during animation? It seems kinda blinking/clashing. Or has it been changed since the newest commits? You might want to see a new demo. 🤔 |
I think that glitch comes from Theme.MaterialComponents. |
@bojankoma How? Any reason behind this? |
I assume that's related to #4, which was fixed in |
Okay, I gave the forked repository a try and didn't encounter any weird behavior. It might have been resolved with the last release. Thanks! @waseefakhtar can you please update the demo gif? |
@nuhkoca I think the animations for enter or exit are different. I didn't go deep into codebase but I already noticed some key differences between using Theme.Appcompat and Theme.MaterialComponents as your app theme. |
@bojankoma Interesting. Possible for you to share a video? |
6698d75
to
01514fc
Compare
Sorry it took me way too long to merge this PR. Thanks for contributing @waseefakhtar! |
Implementing #1
Demo:
TODO:
setGroupVisible
currently hides the group but does not adjust the menu height.setGroupCheckable
.setGroupEnabled
is functional but the group state stays the same. (Perhaps we could add color states for disabled items)Also, it'd be nice to add icons for the sample grouped menu items. I can add them if there's an icon set you've already used for the other items that I can have access to.