New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard support #4

Merged
merged 3 commits into from Sep 25, 2018

Conversation

2 participants
@nopdotcom
Copy link
Contributor

nopdotcom commented Sep 20, 2018

dehydrated needs v0.6.x to support wildcards. It also needs --alias when generating a wildcard cert.

@deiwin deiwin requested a review from ostankin Sep 24, 2018

Show resolved Hide resolved dns-certbot.sh Outdated
Show resolved Hide resolved Dockerfile
Show resolved Hide resolved Dockerfile Outdated
Show resolved Hide resolved wildcard-example Outdated
Show resolved Hide resolved wildcard-example Outdated
Show resolved Hide resolved dns-certbot.sh Outdated
Code cleanup: sh variables, ACME v2 staging, touch-ups
@ostankin (politely) points out that I didn't actually test this PR before submitting it. My apologies for your time, and thank you for the clear revision requests. I still have not tested this in the *non-alias* environment. If you think it's important, I'll set up a non-delegated domain.

I've cleaned up the sh errors. (If nothing else, I should always run `shellcheck` before commit.) I like `-u` and I'll start adding it elsewhere.

I've updated the sed replacements to search-and-replace both v1 and v2 URLS from https://letsencrypt.org/docs/acme-protocol-updates/ . Out of caution, I am keeping v1. Let me know if that is incorrect.
@ostankin
Copy link
Member

ostankin left a comment

Thank you!

@ostankin ostankin merged commit edc7843 into salemove:master Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment