Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps #599

Merged
merged 60 commits into from Jul 22, 2020
Merged

Apps #599

merged 60 commits into from Jul 22, 2020

Conversation

AlicjaSzu
Copy link
Contributor

@AlicjaSzu AlicjaSzu commented Jul 9, 2020

PR intended to be tested with API branch: feature/extending_app_support

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

Test environment config

API_URI=https://apps.staging.saleor.rocks/graphql/

@AlicjaSzu AlicjaSzu self-assigned this Jul 9, 2020
@github-actions github-actions bot temporarily deployed to apps July 9, 2020 18:58 Inactive
@github-actions github-actions bot temporarily deployed to apps July 9, 2020 18:58 Inactive
@github-actions github-actions bot temporarily deployed to apps July 9, 2020 18:58 Inactive
@github-actions github-actions bot temporarily deployed to apps July 9, 2020 18:58 Inactive
@github-actions github-actions bot temporarily deployed to apps July 9, 2020 18:59 Inactive
@github-actions github-actions bot temporarily deployed to apps July 9, 2020 18:59 Inactive
@github-actions github-actions bot temporarily deployed to apps July 9, 2020 18:59 Inactive
@github-actions github-actions bot temporarily deployed to apps July 9, 2020 19:03 Inactive
@github-actions github-actions bot temporarily deployed to apps July 9, 2020 19:03 Inactive
@github-actions github-actions bot temporarily deployed to apps July 9, 2020 19:04 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Jul 9, 2020

This pull request introduces 1 alert when merging 9a48688 into ffe0545 - view on LGTM.com

new alerts:

  • 1 for Potentially unsafe external link

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

No coverage uploaded for pull request base (master@df85de6). Click here to learn what that means.
The diff coverage is n/a.

@krzysztofwolski
Copy link
Collaborator

@AlicjaSzu our docs will need update. Please contact @korycins for details.

Copy link
Member

@orzechdev orzechdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very massive, but great PR!

src/apps/components/AppInstallPage/AppInstallPage.tsx Outdated Show resolved Hide resolved
src/apps/mutations.ts Outdated Show resolved Hide resolved
src/apps/mutations.ts Outdated Show resolved Hide resolved
src/apps/views/AppDetails/AppDetails.tsx Show resolved Hide resolved
src/apps/views/AppDetails/AppDetails.tsx Show resolved Hide resolved
src/apps/views/AppDetails/AppDetails.tsx Outdated Show resolved Hide resolved
src/apps/views/AppInstall/AppInstall.tsx Outdated Show resolved Hide resolved
src/apps/views/AppsList/AppsList.tsx Show resolved Hide resolved
src/apps/views/AppsList/AppsList.tsx Show resolved Hide resolved
src/apps/queries.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to apps July 17, 2020 09:47 Inactive
@github-actions github-actions bot temporarily deployed to apps July 17, 2020 09:53 Inactive
@github-actions github-actions bot temporarily deployed to apps July 17, 2020 10:04 Inactive
@@ -4,28 +4,40 @@ schema {
}

type AccountAddressCreate {
errors: [Error!]! @deprecated(reason: "Use typed errors with error codes. This field will be removed after 2020-07-31.")
errors: [Error!]!
@deprecated(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops looks like someone used prettier on this

@@ -11,6 +11,7 @@ All notable, unreleased changes to this project will be documented in this file.
- Handle task failure and fix task duplication - #588 by @dominik-zeglen
- Move fragments to separate directory to avoid circular imports - #592 by @dominik-zeglen
- Add order invoices management - #570 by @orzechdev
- create Apps - #599 by @AlicjaSzu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

Suggested change
- create Apps - #599 by @AlicjaSzu
- Add support for apps - #599 by @AlicjaSzu

import { FormattedMessage, useIntl } from "react-intl";
import ReactMarkdown from "react-markdown";

import activateIcon from "../../../../assets/images/activate-icon.svg";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an alias for this

Suggested change
import activateIcon from "../../../../assets/images/activate-icon.svg";
import activateIcon from "@assets/images/activate-icon.svg";

Copy link
Contributor

@michalina-graczyk michalina-graczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on stage, working fine

Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the merge conflict

@github-actions github-actions bot temporarily deployed to apps July 22, 2020 10:35 Inactive
@krzysztofwolski krzysztofwolski merged commit 211b0b8 into master Jul 22, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants