Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata #670

Merged
merged 18 commits into from Aug 28, 2020
Merged

Add metadata #670

merged 18 commits into from Aug 28, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it adds metadata editors in models.

PR intended to be tested with API branch: master

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to add-metadata August 25, 2020 12:18 Inactive
@github-actions github-actions bot temporarily deployed to add-metadata August 27, 2020 10:01 Inactive
@github-actions github-actions bot temporarily deployed to add-metadata August 27, 2020 14:46 Inactive
@github-actions github-actions bot temporarily deployed to add-metadata August 27, 2020 14:47 Inactive
@github-actions github-actions bot temporarily deployed to add-metadata August 27, 2020 14:47 Inactive
@github-actions github-actions bot temporarily deployed to add-metadata August 27, 2020 14:49 Inactive
@github-actions github-actions bot temporarily deployed to add-metadata August 27, 2020 14:52 Inactive
@dominik-zeglen dominik-zeglen marked this pull request as ready for review August 27, 2020 15:05
@github-actions github-actions bot temporarily deployed to add-metadata August 27, 2020 15:06 Inactive
@patrys
Copy link
Member

patrys commented Aug 27, 2020

@lgtm-com
Copy link

lgtm-com bot commented Aug 27, 2020

This pull request fixes 1 alert when merging d5501b1 into 265c8bc - view on LGTM.com

fixed alerts:

  • 1 for Unused or undefined state property

@@ -134,3 +134,10 @@ export const pluginErrorFragment = gql`
field
}
`;

export const metadataErrorFragment = gql`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promise fulfiled, I appreciate that :D 💪

@github-actions github-actions bot temporarily deployed to add-metadata August 27, 2020 19:00 Inactive
@krzysztofwolski krzysztofwolski merged commit 7770ae3 into master Aug 28, 2020
1 check passed
@krzysztofwolski krzysztofwolski deleted the add/metadata branch August 28, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants