Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Use sdk as a standalone package #724

Merged
merged 9 commits into from May 28, 2020
Merged

Use sdk as a standalone package #724

merged 9 commits into from May 28, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because:
1.
Screenshot 2020-05-21 at 10 56 15
2.
Screenshot 2020-05-21 at 10 56 34

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

@netlify
Copy link

netlify bot commented May 21, 2020

Deploy preview for saleor-storefront-stage processing.

Building with commit 2e57dd4

https://app.netlify.com/sites/saleor-storefront-stage/deploys/5ecfcf22b420230009401a95

@lgtm-com
Copy link

lgtm-com bot commented May 21, 2020

This pull request fixes 1 alert when merging a7f885b into 4d3d249 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@lgtm-com
Copy link

lgtm-com bot commented May 21, 2020

This pull request fixes 1 alert when merging da8d307 into 4d3d249 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

CHANGELOG.md Outdated
@@ -38,6 +38,7 @@ All notable, unreleased changes to this project will be documented in this file.
- Fix unhandled JWT token expiration - #696 by @orzechdev
- Regenerate types - #712 by @dominik-zeglen
- Automatically choose variant attributes from url in ProductVariantPicker - #708 by @AlicjaSzu
- Use sdk as a standalone package - #724 by @dominik-zeglen
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in #Unreleased

@lgtm-com
Copy link

lgtm-com bot commented May 24, 2020

This pull request fixes 1 alert when merging a528520 into 9ffc58e - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

onClick={handleSignOut}
data-cy="mobileMenuLogoutLink"
>
<ReactSVG path={userImg} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it shouldn't be changed from Log Out string, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't, rebase conflicts.

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 1 alert when merging 900e847 into 9c47831 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 1 alert when merging 38c2f1a into 9c47831 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 1 alert when merging 715ee95 into 9c47831 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 1 alert when merging fd7c0b2 into 9c47831 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@dominik-zeglen dominik-zeglen force-pushed the ref/separate-sdk branch 2 times, most recently from 7beabfd to 03e1d91 Compare May 28, 2020 11:49
@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 1 alert when merging 03e1d91 into 9c47831 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 1 alert when merging dd055a0 into 9c47831 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 1 alert when merging dd32ec0 into 9c47831 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 1 alert when merging 74131a9 into 9c47831 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 1 alert when merging e94964b into 9c47831 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 1 alert when merging 2e57dd4 into 9c47831 - view on LGTM.com

fixed alerts:

  • 1 for Clear text storage of sensitive information

@krzysztofwolski krzysztofwolski merged commit 9b36274 into master May 28, 2020
2 checks passed
@krzysztofwolski krzysztofwolski deleted the ref/separate-sdk branch May 28, 2020 15:27
Ninpo pushed a commit to collaborativ-io/saleor-storefront that referenced this pull request Aug 8, 2020
* Use sdk as a standalone package

* Update changelog

* Do not type cache objects

* Use latest sdk version

* Fix paths

* Sort imports

* Fix rebase

* Fix bug causing sdk not to build

* Update sdk version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants