Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Refactor/sdk user auth #727

Merged
merged 32 commits into from Jul 14, 2020
Merged

Refactor/sdk user auth #727

merged 32 commits into from Jul 14, 2020

Conversation

orzechdev
Copy link
Member

@orzechdev orzechdev commented May 22, 2020

I want to merge this change because it simplifies auth in storefront by replacing it entirely with auth api from sdk (saleor/saleor-sdk#4), although there are still some methods not yet replaced by sdk methods, because password and account changing methods still depend on them - and this functionality is not yet available in sdk. Those methods are going to be updated in another pull request.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

@orzechdev orzechdev added wip Work in progress blocked Blocked e.g. by API or some other issue. labels May 22, 2020
@orzechdev orzechdev force-pushed the refactor/sdk-error-handling branch from add5d02 to ef92ffe Compare May 22, 2020 14:30
Base automatically changed from refactor/sdk-error-handling to master May 27, 2020 13:13
@netlify
Copy link

netlify bot commented May 27, 2020

Deploy preview for saleor-storefront-stage processing.

Building with commit be7493a

https://app.netlify.com/sites/saleor-storefront-stage/deploys/5ed1396c7a8ae80007563809

@orzechdev orzechdev removed blocked Blocked e.g. by API or some other issue. wip Work in progress labels May 28, 2020
@orzechdev orzechdev marked this pull request as ready for review May 28, 2020 14:20
@orzechdev orzechdev force-pushed the refactor/sdk-user-auth branch 6 times, most recently from 046ac31 to ed337a0 Compare June 1, 2020 16:55
@github-actions github-actions bot temporarily deployed to refactor-sdk-user-auth July 10, 2020 08:41 Inactive
@github-actions github-actions bot temporarily deployed to refactor-sdk-user-auth July 10, 2020 10:36 Inactive
@github-actions github-actions bot temporarily deployed to refactor-sdk-user-auth July 10, 2020 10:36 Inactive
@github-actions github-actions bot temporarily deployed to refactor-sdk-user-auth July 10, 2020 11:52 Inactive
@orzechdev orzechdev requested a review from AlicjaSzu July 14, 2020 12:11
@github-actions github-actions bot temporarily deployed to refactor-sdk-user-auth July 14, 2020 12:54 Inactive
@github-actions github-actions bot temporarily deployed to refactor-sdk-user-auth July 14, 2020 13:22 Inactive
@github-actions github-actions bot temporarily deployed to refactor-sdk-user-auth July 14, 2020 13:46 Inactive
@dominik-zeglen dominik-zeglen merged commit 4494026 into master Jul 14, 2020
1 check passed
@dominik-zeglen dominik-zeglen deleted the refactor/sdk-user-auth branch July 14, 2020 15:44
@patrys
Copy link
Member

patrys commented Jul 15, 2020

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants