New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop storefront 1.0 #5043
Drop storefront 1.0 #5043
Conversation
I think we can remove:
- LOGIN_URL = "/account/login/"
- PAGINATE_BY = 16
- DASHBOARD_PAGINATE_BY = 30
- DASHBOARD_SEARCH_LIMIT = 5
- LOGOUT_ON_PASSWORD_CHANGE = False
- SOCIAL_AUTH_USERNAME_IS_FULL_EMAIL = True
- SOCIAL_AUTH_USER_MODEL = AUTH_USER_MODEL
- SOCIAL_AUTH_FACEBOOK_SCOPE = ["email"]
- SOCIAL_AUTH_FACEBOOK_PROFILE_EXTRA_PARAMS = {"fields": "id, email"}
- SOCIAL_AUTH_REDIRECT_IS_HTTPS = True
formsettings.py
, and: "saleor.account.backends.google.CustomGoogleOAuth2",
"saleor.account.backends.facebook.CustomFacebookOAuth2",
fromAUTHENTICATION_BACKENDS
insettings.py
.
Can someone check settings too?
@NyanKiyoshi @maarcingebala @krzysztofwolski @korycins
@IKarbowiak I pushed some changes to drop useless middleware, apps, context processors. They are not that heavy on the processing time but save between 15-25% of processing in my tests.
I also removed django-redis as it is no longer needed (no more session caching), django-social, and more–including npm dependencies that are no longer used.
@@ -33,7 +33,6 @@ dist/ | |||
/node_modules/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this? and docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still use npm for build-emails
, so probably node_modules
must stay. But in case of docs
for me, it looks like we can remove it. @maarcingebala, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this probably needs to stay for now since we still have some packages in package.json.
|
||
|
||
@app.task | ||
def update_all_products_minimal_variant_prices_task(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK this task was created to future usage from celery beat. But I am not sure. You can ask @derenio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true, although I'm not sure what's the status of shipping saleor with something like celery beat
for which this task was designed. I think we can remove it. When we implement the default periodic tasks
schema we will have to think about the minimal variant price recalculations.
… into drop-storefront-1.0
Drop storefront 1.0 -> views, forms, templates, statics
Closes #5017
Closes #5046
Pull Request Checklist