Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong advanced filter message in Suite7 and SuiteR themes #3234

Closed
likhobory opened this issue Mar 7, 2017 · 3 comments

Comments

@likhobory
Copy link
Contributor

commented Mar 7, 2017

Wrong advanced filter message after adding to the filter a non-existent criterion.

Expected message

"No results found... Perhaps change your search criteria and try again?"

Actual message

"No results found.
or change your search criteria"

Your Environment

  • SuiteCRM Version used: 7.8.2
@shogunpol

This comment has been minimized.

Copy link

commented Mar 8, 2017

@likhobory , please provide steps to reproduce on real case.

@likhobory

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2017

  1. Select SuiteR theme in user profile
  2. Select List View for some module (Accounts, for example)
  3. Select Filter->Advanced filter
  4. Put some non-exisnent value to the filter field (for example 'йцукен' to account name field as search criteria) and push the search button

default

@shogunpol shogunpol removed the Needs Updates label Mar 8, 2017

@horus68

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2017

@shogunpol instead of the full message from /include/language/en_us.lang.php
'MSG_LIST_VIEW_NO_RESULTS_CHANGE_CRITERIA' => 'No results found... Perhaps change your search criteria and try again?',

'MSG_LIST_VIEW_NO_RESULTS_CHANGE_CRITERIA' => 'No results found... Perhaps change your search criteria and try again?',

There are 2 strings displayed:
'MSG_LIST_VIEW_NO_RESULTS_BASIC' => 'No results found.',

'MSG_LIST_VIEW_NO_RESULTS_BASIC' => 'No results found.',

'MSG_LIST_VIEW_CHANGE_SEARCH' => 'or change your search criteria',

'MSG_LIST_VIEW_CHANGE_SEARCH' => 'or change your search criteria',

This would only be correct if some value is supposed to be displayed in between the 2 strings.

See the usage of 'MSG_LIST_VIEW_CHANGE_SEARCH' (2 files)
https://github.com/salesagility/SuiteCRM/search?utf8=%E2%9C%93&q=%27MSG_LIST_VIEW_CHANGE_SEARCH%27+

@Dillon-Brown Dillon-Brown self-assigned this May 11, 2017

samus-aran added a commit that referenced this issue Jun 1, 2017
Merge pull request #3543 from Dillon-Brown/issue-3234
Fixed #3234 - Wrong advanced filter message in Suite7 and SuiteR themes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.