Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout editor showing incorrect labels in SuiteP. #4220

Closed
bdragon28 opened this issue Sep 7, 2017 · 0 comments

Comments

@bdragon28
Copy link
Contributor

commented Sep 7, 2017

SuiteP is missing an assign in themes/SuiteP/modules/ModuleBuilder/tpls/layoutView.tpl, making it confusing to edit layouts -- it is showing the same title in every non-filler slot.

Issue

Expected Behavior

The layout editor should show appropriate labels on fields.

Actual Behavior

The layout editor uses the last value assigned to $label.

Possible Fix

PR #4221

Steps to Reproduce

  1. Apply pull #4219 so the editor works properly.
  2. Ensure translations are not in use (the translated version does not suffer this issue.
  3. Ensure SuiteP theme is in use.
  4. Edit a custom module's EditView layout. The Layout section accidentally inherits the value of the bottom option in the list of fields, since the variable isn't being updated properly.

Context

After submitting PR #4219 I continued to try and work on a custom module, but immediately ran into this issue, so I debugged it as well.

Your Environment

  • SuiteCRM Version used: hotfix HEAD + pull #4219
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)):
  • Environment name and version (e.g. MySQL, PHP 7):
  • Operating System and version (e.g Ubuntu 16.04):

@Dillon-Brown Dillon-Brown self-assigned this Sep 15, 2017

Dillon-Brown added a commit that referenced this issue Oct 16, 2017
Merge pull request #4221 from bdragon28/bugfix_4220
Fixed #4220 -- Layout editor showing incorrect labels in SuiteP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.