Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging calls without Duration causes php to fail #4440

Closed
JBrace1990 opened this issue Oct 23, 2017 · 2 comments

Comments

@JBrace1990
Copy link

commented Oct 23, 2017

Issue

When editing an existing call, if duration is not set then it fails to save

Expected Behavior

Calls should not require duration to be set

Actual Behavior

Page dies and goes to a white screen

Possible Fix

change "isset" to "!empty"
file: modules/Calls/Call.php
line: 182

Steps to Reproduce

  1. Create a new call, with no duration (optionally, hide duration field from edit view)
  2. Edit the call
  3. Save the call
  4. End up at a white page

Context

Semi-High priority. Makes it impossible to save calls without a duration associated with it.

Your Environment

  • SuiteCRM Version used: 7.8.8
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)):
  • Environment name and version (e.g. MySQL, PHP 7):
  • Operating System and version (e.g Ubuntu 16.04):
@pgorod

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2017

There is a decision to be made here

  • either drop the requirement that the Duration field is mandatory
  • or make it give a proper error when it is empty and somebody tried to save an edit, like it already does when you neglect to fill in the field when creating the record
@JBrace1990

This comment has been minimized.

Copy link
Author

commented Oct 31, 2017

I really don't think the Duration field should be mandatory. If you want to include it, then you can, but for our usage it doesn't really matter.

At the least, the page shouldn't just die like that if it's empty. It needs a JS check if it'll be mandatory, but it really just needs a backend fix to prevent it from trying to make a date object from null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.