Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Logging calls without Duration causes php to fail #4440
When editing an existing call, if duration is not set then it fails to save
Calls should not require duration to be set
Page dies and goes to a white screen
change "isset" to "!empty"
Steps to Reproduce
Semi-High priority. Makes it impossible to save calls without a duration associated with it.
There is a decision to be made here
I really don't think the Duration field should be mandatory. If you want to include it, then you can, but for our usage it doesn't really matter.
At the least, the page shouldn't just die like that if it's empty. It needs a JS check if it'll be mandatory, but it really just needs a backend fix to prevent it from trying to make a date object from null.