New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose Targets Campaigns error last step #6025

Closed
maverikmaverik opened this Issue Jun 13, 2018 · 14 comments

Comments

Projects
None yet
8 participants
@maverikmaverik

maverikmaverik commented Jun 13, 2018

Issue

Expected Behavior

Actual Behavior

Possible Fix

Steps to Reproduce

The error is when you create a Newsletter campaign with both version 7.10.5 and 7.10.6

  1. Launch wizard -> step Target Lists -> select Target
  2. Next step Templates, back to step previous, loses the target list and appears in the list of new target lists that I have not created.
  3. In the step Send Email and Summary, as it loses the target lists, Choose Targets with red blade

screenshot_0
screenshot_2
screenshot_3
screenshot_5
screenshot_6
screenshot_7

Context

suiteCRM forum
TOPIC: Choose Targets Campaigns error last step

I tried it in the official demo with Newsletter type.

It is clearly a bug as you highlighted.

  1. If you navigate back no target list remains selected.
  2. However if you exit from the creation of the Campaign and go to the list view, then select the campaign, in Edit view all available target lists are selected.

This a very dangerous and nasty bug, high priority

This is a critical issue because if one does't realise the problem he may end up sending a newsletter to all atrget lists created in the system and this is really unwanted and against GDPR

Your Environment

  • SuiteCRM Version used: 7.10.5 and 7.10.6
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): all browsers
  • Environment name and version (e.g. MySQL, PHP 7): Mysql an php7
  • Operating System and version (e.g Ubuntu 16.04): Centos
@pgorod

This comment has been minimized.

Contributor

pgorod commented Jun 13, 2018

@maverikmaverik

This comment has been minimized.

maverikmaverik commented Jun 13, 2018

No is the same problem, the one you mention is another that is not solved either, but it is independent of this other one.

@ApatheticCosmos

This comment has been minimized.

Contributor

ApatheticCosmos commented Jun 13, 2018

That javascript error is being triggered by line 294 in modules/Campaigns/tpls/WizardCampaignTargetListForNonNewsLetter.tpl
document.getElementById('no_targets').style.display = 'none';
'no_targets' is not in the DOM.

Why is the file named 'ForNonNewsLetter'? We're creating a newsletter... Is it using the wrong template?

@gymad

This comment has been minimized.

Contributor

gymad commented Jun 14, 2018

@ApatheticCosmos, @maverikmaverik - Thank you for the very well detailed issue report. I found a possible fix for this issue, can you please confirm if it's works now, if you apply my change above?

@ApatheticCosmos

This comment has been minimized.

Contributor

ApatheticCosmos commented Jun 14, 2018

@gymad It now has
[Campaign Header> [Subscriptions> [Templates> at the top instead of
[Campaign Header> [Target List> [Templates>
and the javascript error is gone.

There is also a note on the Subscriptions page that says:

Each campaign requires target lists for subscription, unsubscription and test. When a list is not specified, an empty target list will be created on save.

I think this is the proper behavior, but @maverikmaverik should test in his environment to make sure it's fully working.

@maverikmaverik

This comment has been minimized.

maverikmaverik commented Jun 15, 2018

Produces a new error, it is not correct, the screen goes blank

screenshot_1
screenshot_2
screenshot_3

@maverikmaverik

This comment has been minimized.

maverikmaverik commented Jun 15, 2018

It is not closed, it has not been resolved yet.

I do not know why it's closed

@samus-aran

This comment has been minimized.

Contributor

samus-aran commented Jun 15, 2018

@maverikmaverik It appears you had closed it (perhaps by mistake?) looking at the activity stream.
Are you able to provide some logs to identify that 500 error. I suspect it could be permissions, did you reapply correct permissions when you applied the file changes from the proposed pull request?

@gymad Can you assist and help out.

@maverikmaverik

This comment has been minimized.

maverikmaverik commented Jun 15, 2018

themes permissions 775

@samus-aran

This comment has been minimized.

Contributor

samus-aran commented Jun 15, 2018

@maverikmaverik logs?
That would give a more accurate description of causing a 500.

@maverikmaverik

This comment has been minimized.

maverikmaverik commented Jun 15, 2018

error_log and suitecrm_log do not give any

screenshot_4

@gymad

This comment has been minimized.

Contributor

gymad commented Jun 15, 2018

@maverikmaverik we can not replicate the blank screen, I assume there is a mistake in your colourSelector.php but it seems correct in the current branch, however 500 server error means something wrong in the server itself (like file permission) or it could be a syntax or parse error in the php interpreter. You can look into your apache log to find an error message (using the correct php.ini settings). if it does not helps also would be nice to see what is in the POST data below in your console log:
image

Dillon-Brown added a commit that referenced this issue Jun 18, 2018

Merge pull request #6034 from gymad/hotfix_issue_6025
Fixed #6025 - Fix for issue #6025 - Newsletter campaign target list selection broken
@jfd118

This comment has been minimized.

jfd118 commented Jul 26, 2018

I am using V7.10.7 and the same problem occurs when creating an email campaign. The "Target List" not select error appears.

@mcolangelo

This comment has been minimized.

mcolangelo commented Sep 20, 2018

I am using 7.10.8 and have the same issue. I can execute a test email, but I am manually selecting the Send Test action button and then selecting my email campaign which will send successfully at that time.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment