Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.10.x-hotfix CI is failing #7310

Closed
connorshea opened this issue May 24, 2019 · 0 comments
Closed

7.10.x-hotfix CI is failing #7310

connorshea opened this issue May 24, 2019 · 0 comments
Labels
Priority:Critical Issues & PRs that are critical; broken core functionality, fatal errors - there are no workarounds Type:Bug Bugs within the core SuiteCRM codebase
Milestone

Comments

@connorshea
Copy link
Contributor

Issue

Travis CI is failing on the 7.10.x-hotfix branch. It looks like the failing test was introduced by #7277. For example: https://travis-ci.org/salesagility/SuiteCRM/jobs/536800018

Expected Behavior

The test suite passes.

Actual Behavior

The test suite does not pass. Specifically, the API test suite.

--------
1) GetFieldsMetaCest: Should not work | "withInvalidModuleName","/Api/V8/meta/fields/FooBar","Module FooBar does not exist"
 Test  tests/api/V8/GetFieldsMetaCest.php:shouldNotWork
Failed asserting that two strings are equal.
- Expected | + Actual
@@ @@
'{
"errors": {
"status": 400,
"title": null,
-        "detail": "Module FooBar does not exist"
+        "detail": "[SuiteCRM] [API] [Not Allowed] The API user does not have access to this module."
}
}'
Scenario Steps:
 16. $I->seeResponseEquals("{\n    "errors": {\n        "status": 400,\n   ...") at tests/api/V8/GetFieldsMetaCest.php:71
 15. $I->seeResponseIsJson() at tests/api/V8/GetFieldsMetaCest.php:70
 14. $I->seeResponseCodeIs(400) at tests/api/V8/GetFieldsMetaCest.php:69
 13. $I->sendGET("http://localhost/Api/V8/meta/fields/FooBar") at tests/api/V8/GetFieldsMetaCest.php:68
 12. $I->getInstanceURL() at tests/api/V8/GetFieldsMetaCest.php:57
 11. $I->canSeeResponseIsJson() at tests/_support/ApiTester.php:245
FAILURES!
Tests: 14, Assertions: 96, Failures: 1, Incomplete: 2.
The command "./vendor/bin/codecept run tests/api/V8/ -f --ext DotReporter" exited with 1.

Possible Fix

The test is in GetFieldsMetaCest.php. I'm not sure if the 'Not Allowed' error is what should actually be expected, or if the API has a bug and "Module FooBar does not exist" is the correct expectation.

Either way, it should be fixed :)

@PedroErnst PedroErnst mentioned this issue May 27, 2019
6 tasks
@Dillon-Brown Dillon-Brown added Type:Bug Bugs within the core SuiteCRM codebase Priority:Critical Issues & PRs that are critical; broken core functionality, fatal errors - there are no workarounds Resolved: Next Release labels May 29, 2019
@Dillon-Brown Dillon-Brown added this to the 7.11.5 milestone May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Critical Issues & PRs that are critical; broken core functionality, fatal errors - there are no workarounds Type:Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Development

No branches or pull requests

3 participants