Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Default Value in Importer #3218

Merged
merged 3 commits into from Sep 21, 2017

Conversation

@sgaved
Copy link
Contributor

commented Mar 3, 2017

Description

When you are importing, on Step 3 you can click "< Default Value". After clicking this the option to hide it again should be shown with "> Default Value". It is not currently shown and is just blank.
This Fixes that issue

Motivation and Context

Allow you to hide the default value entry.

How To Test This

Try importing and clicking default value and see that it is blank. Apply fix and see that you can now hide it again.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.
sgaved added 2 commits Mar 3, 2017
@daniel-samson

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2017

@Dillon-Brown Please assess?

@Dillon-Brown Dillon-Brown changed the base branch from hotfix to hotfix-7.8.x Sep 18, 2017

Revert "Update README.md"
This reverts commit 76cc349.

@Dillon-Brown Dillon-Brown merged commit 58da833 into salesagility:hotfix-7.8.x Sep 21, 2017

2 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.