Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix 7.8.x # Improvement in parameters for dashlet reports #4474

Merged
merged 2 commits into from Apr 24, 2018

Conversation

@LionelBino
Copy link
Contributor

commented Nov 1, 2017

Description

In some situations getConditionsAsParameters() in file modules/AOR_Reports/aor_utils.php line 161, return a array $conditions=>field that contain a input tag like this:

<input type="text" name="parameter_value[5]" id="parameter_value[5]" size="30" maxlength="255" value="3" title="" tabindex="1">

For this reason, the input form values are like this:

<div id="">
    <input type="hidden" name="parameter_id[]" value="7d0d3274-b3f7-6467-6a0b-57e2ae3f07c5">
    <input type="hidden" name="parameter_operator[]" value="Equal_To">
    <input type="hidden" name="parameter_type[]" value="Value">
    Account - <em>ID Seller</em> - Like to 
    <input type="text" name="parameter_value[5]" id="parameter_value[5]" size="30" maxlength="255" value="3" title="" tabindex="1">
</div>

For this reason the value in input can't be catched and the report cannot obtain this parameter

Motivation and Context

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.
LionelBino added 2 commits Nov 1, 2017
@gunnicom

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2017

Maybe this is related to #1710 ?

@LionelBino

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2017

Yes it's related exact to this #1710

@gunnicom

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2017

Maybe you can have a look how i fixed it, and see if that would work for you, as mine was less change, and does look cleaner to me.

@gymad
gymad approved these changes Apr 23, 2018
@Dillon-Brown

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2018

Assessed

Approved with PullApprove

@Dillon-Brown Dillon-Brown merged commit 889ffd7 into salesagility:hotfix-7.8.x Apr 24, 2018

3 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
code-review/pullapprove Approved by all reviewer groups.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Dillon-Brown Dillon-Brown referenced this pull request Apr 8, 2019
3 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.