Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #7675 - Add a function to compare properly indices definitios #7746

Merged

Conversation

@Abuelodelanada
Copy link
Contributor

Abuelodelanada commented Aug 24, 2019

Description

This PR fixes #7675

Motivation and Context

See #7675

How To Test This

  1. Go to on admin
  2. Click on quick repair and rebuild
  3. Verify that (if you have already created in DB) the following index it is not created again:
ALTER TABLE users DROP INDEX idx_user_name, ADD INDEX idx_user_name (user_name,is_group,status,last_name (30),first_name (30),id);

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 24, 2019

Codecov Report

Merging #7746 into hotfix-7.10.x will decrease coverage by 0.13%.
The diff coverage is 41.66%.

@@                Coverage Diff                @@
##           hotfix-7.10.x    #7746      +/-   ##
=================================================
- Coverage            7.4%    7.27%   -0.14%     
=================================================
  Files               3747     3697      -50     
  Lines             392147   385926    -6221     
=================================================
- Hits               29057    28091     -966     
+ Misses            363090   357835    -5255
Copy link
Contributor

connorshea left a comment

@Abuelodelanada I applied the patch (Open https://github.com/salesagility/SuiteCRM/pull/7746.patch, save it as a .patch file, then run git apply path/to/file.patch) to our CRM running 7.10.19 and this fixed the Repair process complaining about an index mismatch 👍

@Abuelodelanada

This comment has been minimized.

Copy link
Contributor Author

Abuelodelanada commented Aug 28, 2019

Confirmed too by @holdusback in #7675 (comment)

Copy link
Contributor

connorshea left a comment

Worked for me 👍

cumanacr added a commit to lionixevolve/LionixCRM that referenced this pull request Sep 10, 2019
@cameronblaikie

This comment has been minimized.

Copy link
Contributor

cameronblaikie commented Sep 10, 2019

Assessed 👍

@Dillon-Brown Dillon-Brown merged commit 0c4e1f0 into salesagility:hotfix-7.10.x Sep 10, 2019
4 checks passed
4 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
codecov/project 7.27% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Abuelodelanada Abuelodelanada deleted the gcoop-libre:hotfix-7.10.x_7675 branch Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.