Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #7781 - Now we can compile SuiteP only one color_scheme #7782

Merged

Conversation

@Abuelodelanada
Copy link
Contributor

Abuelodelanada commented Aug 29, 2019

Description

Read #7781

Motivation and Context

Read #7781

How To Test This

Run:

$ ./vendor/bin/robo build:suite-p --color_scheme Dawn 

And verify that only Dawn color_scheme is compiled

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #7782 into hotfix-7.10.x will increase coverage by <.01%.
The diff coverage is 0%.

@@                Coverage Diff                @@
##           hotfix-7.10.x    #7782      +/-   ##
=================================================
+ Coverage           7.27%    7.27%   +<.01%     
=================================================
  Files               3697     3697              
  Lines             385907   385908       +1     
=================================================
+ Hits               28085    28090       +5     
+ Misses            357822   357818       -4
Copy link
Contributor

connorshea left a comment

LGTM

@Mac-Rae

This comment has been minimized.

Copy link
Contributor

Mac-Rae commented Sep 9, 2019

Assessed 👍

@Dillon-Brown Dillon-Brown merged commit cf7e907 into salesagility:hotfix-7.10.x Sep 9, 2019
4 checks passed
4 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
codecov/project 7.27% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Abuelodelanada Abuelodelanada deleted the gcoop-libre:hotfix-7.10.x_7781 branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.