Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #7780 - Bad css format in Date and Date Range Inputs in search forms #7783

Merged

Conversation

@Abuelodelanada
Copy link
Contributor

Abuelodelanada commented Aug 30, 2019

Description

Read #7780

Motivation and Context

Improve SuiteCRM Date and Date Range Inputs look&feel

Modal Search

In this example we removed useless free space:

fecha_fix1

DateSearchModal_Fix

Legacy Search

In this example we removed useless free space too and the option selecter fits in the combo.

fecha_fix2

DateSearchForm_Fix

How To Test This

Open modal search in any module (for example Opportunities) and verify in date Range inputs.

To enable legacy search form include this in config_override.php

$sugar_config['enable_legacy_search'] = array(
    'Opportunities',
);

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.
@Abuelodelanada Abuelodelanada changed the title Hotfix 7.10.x 7780 Fix bad css format in Date Range Input in search forms Aug 30, 2019
@Abuelodelanada Abuelodelanada changed the title Fix bad css format in Date Range Input in search forms FIX #7780 - Bad css format in Date Range Input in search forms Aug 30, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #7783 into hotfix-7.10.x will decrease coverage by <.01%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           hotfix-7.10.x    #7783      +/-   ##
=================================================
- Coverage           7.27%    7.27%   -0.01%     
=================================================
  Files               3700     3700              
  Lines             386176   386176              
=================================================
- Hits               28092    28091       -1     
- Misses            358084   358085       +1
@Abuelodelanada Abuelodelanada changed the title FIX #7780 - Bad css format in Date Range Input in search forms FIX #7780 - Bad css format in Date and Date Range Inputs in search forms Aug 31, 2019
@Mac-Rae

This comment has been minimized.

Copy link
Contributor

Mac-Rae commented Sep 16, 2019

Hi @Abuelodelanada, could you look at resolving the conflicts on this PR to allow us to progress this further! Thanks 👍

@Abuelodelanada

This comment has been minimized.

Copy link
Contributor Author

Abuelodelanada commented Sep 16, 2019

Hi @Mac-Rae

As far as I understand the conflicts are because the style.css are 'one-line' compiled files, and are generated by the Robo Task: ./vendor/bin/robo buil:suite-p

As are one-line files every change will produce a conflict in git.

@Abuelodelanada

This comment has been minimized.

Copy link
Contributor Author

Abuelodelanada commented Sep 16, 2019

Hi @Mac-Rae

I merged hotfix-7.10.x into this branch and re-comlipe style.css

I was wondering if we should have style.css under VC...

@Dillon-Brown

This comment has been minimized.

Copy link
Contributor

Dillon-Brown commented Sep 17, 2019

@Abuelodelanada Definitely shouldn't be under VC :), same with minified JS files imo. It's something we'll need to refactor at some point, potentially a Robo task with documentation, compiling on install, etc.

@Abuelodelanada

This comment has been minimized.

Copy link
Contributor Author

Abuelodelanada commented Sep 17, 2019

@Dillon-Brown as far as I understand if those files are removed from VC, two others problems have to be solved:

  • How those files will be compiled when building the .zip file for the SuiteCRM packages.
  • How those files will be compiled in the install process after cloning this repo.

Am I ok with this?

@Dillon-Brown

This comment has been minimized.

Copy link
Contributor

Dillon-Brown commented Sep 17, 2019

@Abuelodelanada Yeah, for the .zip stuff we can easily include it in our package building process so we only really need to handle the clone from repo which I've started here for JS #7340 but I'll need to look at making another PR for the style.css stuff.

Until we refactor this though, we'll just need to keep rebuilding these files in PRs manually like you've done here.

@Mac-Rae

This comment has been minimized.

Copy link
Contributor

Mac-Rae commented Sep 17, 2019

Assessed 👍

@Mac-Rae Mac-Rae added the Assessed label Sep 17, 2019
@Dillon-Brown Dillon-Brown merged commit bff7aec into salesagility:hotfix-7.10.x Sep 17, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Abuelodelanada Abuelodelanada deleted the gcoop-libre:hotfix-7.10.x_7780 branch Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.