Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #7836 - Robo task to compile css in a custom theme #7837

Merged

Conversation

@Abuelodelanada
Copy link
Contributor

Abuelodelanada commented Sep 9, 2019

Description

Read #7836

Motivation and Context

Many times it is very useful to have a custom theme (based in SuitP) to modify things in a safe upgrade mode. With this PR we can compile the css of that theme.

Compile the CSS for a theme called "BCCL"

./vendor/bin/robo build:theme --theme=BCCL                                                                         
➜  Compile BCCL Theme (SASS)
➜  Found style.css for Dusk, Removing
➜  Found style.scss for Dusk, Compiling
 [Exec] Running ./vendor/bin/pscss -f compressed themes/BCCL/css/Dusk/style.scss > themes/BCCL/css/Dusk/style.css
 [Exec] Done in 18.49s
➜  Found style.css for Night, Removing
➜  Found style.scss for Night, Compiling
 [Exec] Running ./vendor/bin/pscss -f compressed themes/BCCL/css/Night/style.scss > themes/BCCL/css/Night/style.css
 [Exec] Done in 18.618s
➜  Found style.css for Dawn, Removing
➜  Found style.scss for Dawn, Compiling
 [Exec] Running ./vendor/bin/pscss -f compressed themes/BCCL/css/Dawn/style.scss > themes/BCCL/css/Dawn/style.css
 [Exec] Done in 21.595s
➜  Found style.css for Day, Removing
➜  Found style.scss for Day, Compiling
 [Exec] Running ./vendor/bin/pscss -f compressed themes/BCCL/css/Day/style.scss > themes/BCCL/css/Day/style.css
 [Exec] Done in 19.919s
➜  Could not open the folder: custom/themes/BCCL/css/

Compile the CSS for a theme called "BCCL" and specific subtheme "Day"

$ ./vendor/bin/robo build:theme --theme=BCCL --color-scheme=Day                                                      
➜  Compile BCCL Theme (SASS)
 [Exec] Running ./vendor/bin/pscss -f compressed themes/BCCL/css/Day/style.scss > themes/BCCL/css/Day/style.css
 [Exec] Done in 18.387s
➜  Compile BCCL Theme (SASS) Complete

And of course you can compile SuiteP theme too:

./vendor/bin/robo build:theme --theme=SuiteP --color-scheme=Day                                                    
➜  Compile SuiteP Theme (SASS)
 [Exec] Running ./vendor/bin/pscss -f compressed themes/SuiteP/css/Day/style.scss > themes/SuiteP/css/Day/style.css
 [Exec] Done in 18.5s
➜  Compile SuiteP Theme (SASS) Complete

How To Test This

Run the tasks mentioned above ;-)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 9, 2019

Codecov Report

Merging #7837 into hotfix-7.10.x will increase coverage by <.01%.
The diff coverage is 0%.

@@                Coverage Diff                @@
##           hotfix-7.10.x    #7837      +/-   ##
=================================================
+ Coverage           7.27%    7.27%   +<.01%     
=================================================
  Files               3699     3699              
  Lines             386144   386152       +8     
=================================================
+ Hits               28088    28090       +2     
- Misses            358056   358062       +6
@Mac-Rae

This comment has been minimized.

Copy link
Contributor

Mac-Rae commented Sep 10, 2019

Looks to be alright, Assessed 👍

@Mac-Rae Mac-Rae added the Assessed label Sep 10, 2019
@Dillon-Brown Dillon-Brown merged commit b0ab7b6 into salesagility:hotfix-7.10.x Sep 10, 2019
4 checks passed
4 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
codecov/project 7.27% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Abuelodelanada Abuelodelanada deleted the gcoop-libre:hotfix-7.10.x-7836 branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.