Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesFIX #7836 - Robo task to compile css in a custom theme #7837
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Sep 9, 2019
Codecov Report
@@ Coverage Diff @@
## hotfix-7.10.x #7837 +/- ##
=================================================
+ Coverage 7.27% 7.27% +<.01%
=================================================
Files 3699 3699
Lines 386144 386152 +8
=================================================
+ Hits 28088 28090 +2
- Misses 358056 358062 +6 |
This comment has been minimized.
This comment has been minimized.
Looks to be alright, Assessed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Abuelodelanada commentedSep 9, 2019
Description
Read #7836
Motivation and Context
Many times it is very useful to have a custom theme (based in SuitP) to modify things in a safe upgrade mode. With this PR we can compile the css of that theme.
Compile the CSS for a theme called "BCCL"
Compile the CSS for a theme called "BCCL" and specific subtheme "Day"
And of course you can compile SuiteP theme too:
How To Test This
Run the tasks mentioned above ;-)
Types of changes
Final checklist