Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #7870 - Improvements in css for date_input and labels in EditView #7871

Merged
merged 6 commits into from Sep 18, 2019

Conversation

@Abuelodelanada
Copy link
Contributor

Abuelodelanada commented Sep 16, 2019

Description

Read #7870

date_input field fixed:

Before:

fecha1

After:

fecha2

Long labels does not overlaps:

Before:

valor1

After:

valor2

Motivation and Context

Improve SuiteP theme

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.
@Mac-Rae

This comment has been minimized.

Copy link
Contributor

Mac-Rae commented Sep 17, 2019

Looks good other than the fix doesn't work in a low phone like resolution
Screenshot from 2019-09-17 12-51-55

@Abuelodelanada

This comment has been minimized.

Copy link
Contributor Author

Abuelodelanada commented Sep 17, 2019

Thanks for the feedback @Mac-Rae

It's solved:

imagen

@Mac-Rae

This comment has been minimized.

Copy link
Contributor

Mac-Rae commented Sep 17, 2019

@Abuelodelanada Great!, will retest and get back to you

@Mac-Rae

This comment has been minimized.

Copy link
Contributor

Mac-Rae commented Sep 17, 2019

Could you push the branch again to resolve the conflicts or allow contributor access and we can do it for you.

@Abuelodelanada

This comment has been minimized.

Copy link
Contributor Author

Abuelodelanada commented Sep 17, 2019

@Mac-Rae Let me know if everything is ok

@cameronblaikie

This comment has been minimized.

Copy link
Contributor

cameronblaikie commented Sep 18, 2019

@Abuelodelanada Looks good! Assessed 👍

@Mac-Rae Mac-Rae merged commit d3fb5b8 into salesagility:hotfix-7.10.x Sep 18, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Abuelodelanada Abuelodelanada deleted the gcoop-libre:hotfix-7.10.x_7870 branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.