Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #7875 - Wrong render in DateRangeInput using "Between" Option #7877

Merged

Conversation

@Abuelodelanada
Copy link
Contributor

Abuelodelanada commented Sep 17, 2019

Description

Read #7875

Motivation and Context

Make SuiteCRM looks cuter ;-)

How To Test This

  1. Open a search form with a DateRange widget
  2. Select Between option
  3. Verify the how is rendered

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.
Copy link
Contributor

connorshea left a comment

I applied this patch to our CRM running 7.10.19 and it does indeed fix the problem, LGTM 👍

Before
Screen Shot 2019-09-18 at 10 17 48 AM

After
Screen Shot 2019-09-18 at 10 19 23 AM

@cameronblaikie

This comment has been minimized.

Copy link
Contributor

cameronblaikie commented Sep 23, 2019

Assessed 👍

@Dillon-Brown Dillon-Brown merged commit e42180a into salesagility:hotfix-7.10.x Sep 23, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Abuelodelanada Abuelodelanada deleted the gcoop-libre:hotfix-7.10.x_7875 branch Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.