Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #8063 - Change isset() to !empty() #8064

Merged

Conversation

@Abuelodelanada
Copy link
Contributor

Abuelodelanada commented Oct 15, 2019

Description

Read #8063

Motivation and Context

The users couldn't go to the DetailView of the Notes they were creating.

How To Test This

  1. Create and Role and assign an user to this Role.
  2. Set the followings permissions to the module Notes for this Role:
access: 89
delete: -99
edit: 75
export: -99
import: -99
list: 75
view: 75
  1. Login with this user
  2. Create a Note
  3. Verify you can go to the DetailView.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #8064 into hotfix-7.10.x will increase coverage by <.01%.
The diff coverage is 100%.

@@                Coverage Diff                @@
##           hotfix-7.10.x    #8064      +/-   ##
=================================================
+ Coverage          10.48%   10.49%   +<.01%     
=================================================
  Files               3325     3325              
  Lines             243808   243802       -6     
=================================================
+ Hits               25575    25586      +11     
+ Misses            218233   218216      -17
@Mac-Rae

This comment has been minimized.

Copy link
Contributor

Mac-Rae commented Oct 17, 2019

Assessed 👍

@Mac-Rae Mac-Rae added Assessed and removed In Review labels Oct 17, 2019
@cameronblaikie cameronblaikie merged commit 41ee4de into salesagility:hotfix-7.10.x Oct 17, 2019
4 checks passed
4 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
codecov/project 10.49% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Abuelodelanada Abuelodelanada deleted the gcoop-libre:hotfix-7.10.x-8063 branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.