Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #2857 - No dynamic refreshing in dashboard #9479

Merged
merged 1 commit into from Feb 28, 2022

Conversation

marcoblancas
Copy link
Contributor

The reload icon in every dashlet was reloading all the dashboard.

With my fix it reloads just the dashlet requested as in previous versions of suiteCRM.

Description

My code just replace the onclick function in the themes/SuiteP/include/Dashlets/DashletHeader.tpl

Motivation and Context

User use to have a lot of dashlets in their dashboards and performance in big databeses is penalized. By other hand users has no way to understand which of their dashlets are slow. Reloading dinamicaly just the targeted dashlet they can experiment to remove slow and not so useful dashlets.

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@jack7anderson7
Copy link
Contributor

Hi @marcoblancas,

Could you please rebase your hotfix PR on to the latest hotfix and push back up as it appears you have a commit that has already been merged into hotfix as part of your PR.

Could you please do the same for other PR #9481 as well.

Thanks,
Jack

@jack7anderson7 jack7anderson7 added the Status:Requires Updates Issues & PRs which requires input or update from the author label Feb 9, 2022
The reload icon in every was reloading all the dashboard.
Now it reloads just the dashlet requested as in previous versions
@marcoblancas
Copy link
Contributor Author

@jack7anderson7, now it is rebased to hotfix

@jack7anderson7 jack7anderson7 removed the Status:Requires Updates Issues & PRs which requires input or update from the author label Feb 22, 2022
@mattlorimer mattlorimer added Branch:Hotfix Status: Ready to Merge PRs that have passed QA & can be merged into next release batch Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member labels Feb 28, 2022
@mattlorimer mattlorimer merged commit f3dff18 into salesagility:hotfix Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Ready to Merge PRs that have passed QA & can be merged into next release batch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants