New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug on `scss/dependencies/core.scss` #173

Closed
3den opened this Issue Mar 18, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@3den

3den commented Mar 18, 2016

I have installed slds with bower and I and getting an error Invalid CSS after "": expected selector, was "" when it is included.

// application.scss
@import "salesforce-lightning-design-system/scss/index";
// the @import above throws => Invalid CSS after "": expected selector, was ""

The error is on scss/dependencies/core.scss:24.

@mixin core($scoped: null, $globals: null) {
  @if $scoped == 'scoped' {
    $scoped-selector: '&';
    $scoped-root:     $scoped-selector;
    $scoped-body:     '&:not(html), body';
  }

  $scoped-selector: '' !default;
  $scoped-root:     'html' !default;
  $scoped-body:     'body' !default;

  // This will throw and error because it will try to create a style with no selector...
  // the fix is to skip this code instead of creating a bogus selector  
  #{$scoped-selector} {
    ...
  }
  ...
}

@3den 3den referenced this issue Mar 18, 2016

Closed

fix invalid selector on core mixin #174

1 of 1 task complete
@kaelig

This comment has been minimized.

Contributor

kaelig commented Mar 18, 2016

Thank you @3den, we were actually fixing this today!

In the mean time, a workaround is to use node-sass instead of Ruby Sass. Thank you for your patience and apologies for the inconvenience.

@kaelig kaelig added the bug label Mar 18, 2016

@kaelig kaelig self-assigned this Mar 18, 2016

@3den

This comment has been minimized.

3den commented Mar 18, 2016

@kaelig i sent a PR to fix that bug already please take a look => #174

@3den

This comment has been minimized.

3den commented Mar 18, 2016

if you need more changes there please let me known and I can do it.

@kaelig

This comment has been minimized.

Contributor

kaelig commented Apr 9, 2016

Thank you for your patience, this was just fixed in the latest version of the Lightning Design System!

See full release notes: https://www.lightningdesignsystem.com/release-notes/

@kaelig kaelig closed this Apr 9, 2016

@3den

This comment has been minimized.

3den commented Apr 9, 2016

:+100:

tamzi pushed a commit to tamzi/design-system that referenced this issue Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment