Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLDS minified css file inconsistent between managed and unmanaged packages. #342

Closed
suryatej16 opened this issue Oct 27, 2016 · 8 comments
Closed
Labels

Comments

@suryatej16
Copy link

I am using the minified 2.1.3 version of the SLDS css file in a package I am working on. I am noticing inconsistencies, mainly with the calc() function, in the css file between my dev org and when I create a managed package. Here is one example, the Process bar:

If you notice below, the arrows between the steps are properly rendered, with the CSS as follows:
.slds-tabs--path__item:before{content:'';display:block;position:absolute;top:2px;left:-1rem;width:calc(2rem - (2px * 2));height:calc(2rem - (2px * 2));

Notice the spacing between the items in the calc() function.

correctlyrendered

This is when I create a managed package from my code. Notice the arrows are not rendered here, and the css for this is as follows:
.slds-tabs--path__item:before{content:'';display:block;position:absolute;top:2px;left:-1rem;width:calc(2rem -(2px * 2));height:calc(2rem -(2px * 2));

Notice that the spacing in the calc() function is now different, the minus sign and the parenthetical expression no longer have a space between them.

incorrectlyrendered

Has anyone encountered inconsistencies like these before? I understand this might not be the proper forum for this question, and if not, could someone direct me to a better place?

@kaelig
Copy link
Contributor

kaelig commented Oct 27, 2016

Good catch, @suryatej16! Thank you for sharing and asking.

I'll need to know how you got the CSS that's in your managed package. Where did you download/compile it from?

@suryatej16
Copy link
Author

I downloaded it from the following link: https://www.lightningdesignsystem.com/downloads/

The problem isn't in the file that is downloaded. That file is correctly formatted. It's only when the CSS gets uploaded as part of a managed package that the CSS formatting changes.

@kaelig kaelig added the bug label Oct 28, 2016
@kaelig
Copy link
Contributor

kaelig commented Oct 31, 2016

Thanks @suryatej16.

I've tried to reproduce the issue and unfortunately couldn't.

Could you please describe the steps necessary to reproduce the issue and what are the pre-requisites (type of org, access rights…)?

@stefsullrew
Copy link
Contributor

@suryatej16 - is this happening with a managed package in VF or on the platform?

@suryatej16
Copy link
Author

This is happening with a managed package in VF. The steps to reproduce would be to create a VF page in a sample managed package and use the Sales Path navigation component on the page.

@kaelig
Copy link
Contributor

kaelig commented Nov 30, 2016

Thanks, I tried what you describe (at least I think this is what you described), and couldn't reproduce it.

@kaelig
Copy link
Contributor

kaelig commented Dec 9, 2016

@suryatej16 would you mind describing the steps as closely as possible to what you've done so we can try to repeat the issue?

@kaelig
Copy link
Contributor

kaelig commented Jan 25, 2017

Closing this as we couldn't reproduce the issue.

@kaelig kaelig closed this as completed Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants