Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Dynamic Icon Trend Direction/Color Separation #455
I would qualify this as an improvement/feature rather then issue/bug.
Having reviewed the new Dynamic Icons (Looks very nice), I would like to suggest that the direction (up/down) be separated from the color on the trend Icon. We have many different processes/workflow that can lead to UP be either bad or good. The UI conversion of green=good red=bad is here to stay. The strength set allow for going either red/green depending on need. A good example of why I'd vote for a red UP trend icon style is SLA/response times. Longer (up) is a bad outcome there rather then bigger deals/more income which would warrant the UP green coloring. In general, I would suggest spiting the coloring from the direction to increase the flexibility.
Relevant to 3.2.1
I'm not saying that the suggestion is invalid, but that there are many ways for us to work around the native limitation of SLDS in lightning components with the svg color. I agree that the svg should not have a color and should be set by the developer.
All the same, you can still override the svg icon's fill. Here's an example:
Note that the color attribute overrides the color for the component to blue. But if you made this a component you could set it to any color for your svg.