Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.slds-text-link_faux is either wrong in docs or not implemented #505

Closed
mattgoldspink opened this issue Oct 13, 2017 · 3 comments
Closed

.slds-text-link_faux is either wrong in docs or not implemented #505

mattgoldspink opened this issue Oct 13, 2017 · 3 comments
Assignees
Labels

Comments

@mattgoldspink
Copy link

@mattgoldspink mattgoldspink commented Oct 13, 2017

Go to: https://lightningdesignsystem.com/utilities/interactions
And choose "Faux Link On A Span"
Notice nothing happens to the span/link.

From checking the source code it looks like the old BEM format has the class implemented:

.slds-text-link--faux

But the newer one isn't - however there is a new this a new class 'slds-type-focus'

So I'm assuming the docs should describe this class instead.

@engai
Copy link
Contributor

@engai engai commented Dec 20, 2017

@mattgoldspink Hey Matt, looks like you've caught another bug. We'll go ahead and update the our styles and docs. Thanks!

Loading

@engai engai self-assigned this Dec 20, 2017
@engai engai added the bug label Dec 20, 2017
@engai
Copy link
Contributor

@engai engai commented Dec 20, 2017

@mattgoldspink the docs are correct and we've added the new BEM format to our styles. Fix should be available in our next release. Thanks again for pointing out the bug!

Loading

@engai engai closed this Dec 20, 2017
@mattgoldspink
Copy link
Author

@mattgoldspink mattgoldspink commented Dec 21, 2017

Awesome - thanks @engai

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants