New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different label sizes for groups of slds-radio and slds-checkbox #556

Closed
maiwald opened this Issue Jun 4, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@maiwald

maiwald commented Jun 4, 2018

I was wondering why there are different sizes for slds-form-element__label when used in slds-radio and in slds-checkbox. In particular, this was making me wonder:

.slds-form-element__label {
display: inline;
vertical-align: middle;
font-size: $font-size-medium;
}

This is basically taken from the Docs and produces the following result: (https://codepen.io/anon/pen/oybPMw)

screenshot from 2018-06-04 12-40-13

To me, this looks inconsistent or am I using it wrong? Are checkboxes not supposed to be used like this?

@maiwald maiwald changed the title from Different label sizes for groups of `slds-radio`s and `slds-checkbox`s to Different label sizes for groups of slds-radio and slds-checkbox Jun 4, 2018

@stefsullrew stefsullrew added the bug label Jun 6, 2018

@stefsullrew

This comment has been minimized.

Show comment
Hide comment
@stefsullrew

stefsullrew Jun 6, 2018

Member

I do believe you may have found a bug, thanks! We'll investigate.

Member

stefsullrew commented Jun 6, 2018

I do believe you may have found a bug, thanks! We'll investigate.

@ayeshakmaz ayeshakmaz closed this Jun 8, 2018

@ayeshakmaz

This comment has been minimized.

Show comment
Hide comment
@ayeshakmaz

ayeshakmaz Jun 8, 2018

Contributor

We've added a fix for this, thanks for catching it @maiwald!

Contributor

ayeshakmaz commented Jun 8, 2018

We've added a fix for this, thanks for catching it @maiwald!

@maiwald

This comment has been minimized.

Show comment
Hide comment
@maiwald

maiwald Jun 10, 2018

@ayeshakmaz Great, thank you!

maiwald commented Jun 10, 2018

@ayeshakmaz Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment