Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for <legend> in Visualforce specific styles #216

Merged
merged 1 commit into from Aug 1, 2016

Conversation

@thvd
Copy link
Contributor

@thvd thvd commented May 12, 2016

Changes proposed in this PR:

  • Fix bug for <legend> in Visualforce styles. The legend is bold in Visualforce, but it shouldn't be:

selection_306

Preview:

selection_305

@salesforce-ux-bot
Copy link
Contributor

@salesforce-ux-bot salesforce-ux-bot commented May 12, 2016

By analyzing the blame information on this pull request, we identified @aputinski, @stefsullrew and @kaelig to be potential reviewers

@thvd thvd changed the title Fix bug for legend in Visualforce specific styles Fix bug for <legend> in Visualforce specific styles May 12, 2016
@kaelig
Copy link
Contributor

@kaelig kaelig commented May 12, 2016

Thanks for your contribution, @thvd. We really appreciate your help. I'll let @stefsullrew and @brandonferrua review your contribution.

We do require a signed CLA for any contribution, so before we can merge your pull request you'll need to complete the following steps:
https://github.com/salesforce-ux/design-system/blob/master/CONTRIBUTING.md

The good news is that you only have to do this once. Thanks for contributing, and we look forward to integrating your improvements.

@brandonferrua
Copy link
Contributor

@brandonferrua brandonferrua commented Jun 27, 2016

Looks good! Thanks for the contribution!

@thvd
Copy link
Contributor Author

@thvd thvd commented Jul 5, 2016

@kaelig I've signed the Contributor License Agreement.

@kaelig kaelig merged commit 34d0477 into salesforce-ux:master Aug 1, 2016
2 checks passed
@kaelig
Copy link
Contributor

@kaelig kaelig commented Aug 2, 2016

Thank you again for your contribution, @thvd! The fix is part of today's v2.0.3 release 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants