Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding rtl to support to 2.2.x/master branch #438
Note: this is the same as an earlier PR I made but for 2.2.x. I understand this may not be merged, but again we need this for customers, so we have to do it anyway. I hope at somepoint we can see this merged so others may benefit and I'm happy to work with someone in Salesforce to get this done.
Changes proposed in this pull request:
I have gone through every component in the docs - even those we don't use - and fixed them. To do this I modified the
I have left checkbox ticks facing the ltr way (I'm not an expert on rtl languages but what I've seen in the past is a that things like ticks don't change direction just because it's rtl). However the checkbox is position on the alternate side of existing elements.
I did not flip some arrows as I'm not sure if we should create additional CSS rule to use
Salesforce CLA will be signed shortly.
Reviewer, please refer to this "definition of done" checklist:
Some sample screenshots:
@3den Thanks for the feedback - let me work on a different approach for this patch which doesn't use
I think what you said about requiring a seperate CSS file for rtl when a page may contain mixed ltr and rtl text is a pretty big limitation. So I'll see if I can rework this to better handle that case and include some of your other suggestions
Thanks so much for all of your hard work with this contribution, @mattgoldspink ! We are happy to see that you've found a meaningful solution that can work for your customers.
Since we follow a staggered release schedule internally, and because this work on
If you'd still like feedback from us, we are happy to continue the conversation over Github issues. Thanks again!