Adding Array of metadataSeq in RichMap #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tovbinm
reviewed
Aug 20, 2018
| @@ -85,6 +85,11 @@ class RichMetadataTest extends FlatSpec with TestCommon { | |||
| val mergedMetadata = meta1.deepMerge(map2.toMetadata) | |||
| mergedMetadata.json shouldBe Serialization.write(mergedMap) | |||
|
|
|||
| val m1 = Map("1" -> Array(Map("val" -> "a").toMetadata)).toMetadata | |||
There was a problem hiding this comment.
Lets add it as a separate test case
tovbinm
reviewed
Aug 20, 2018
| @@ -100,6 +105,17 @@ class RichMetadataTest extends FlatSpec with TestCommon { | |||
| summaryMeta.containsSummaryMetadata shouldBe true | |||
| } | |||
|
|
|||
| it should "create summary for a given metadata" in { | |||
| val richMetaData = RichMetadata(meta1) | |||
There was a problem hiding this comment.
No need to explicitely wrap metadata into RichMetadata. It should world implicitly.
|
Ooops, I should have waited for the tests to complete. |
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 86.11% 86.18% +0.06%
==========================================
Files 298 298
Lines 9303 9762 +459
Branches 304 531 +227
==========================================
+ Hits 8011 8413 +402
- Misses 1292 1349 +57
Continue to review full report at Codecov.
|
ericwayman
pushed a commit
that referenced
this pull request
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RichMap, for Array values, we are currently accepting booleanSeq, intSeq, longSeq, doubleSeq and stringSeq.