diff --git a/components/combobox/__docs__/__snapshots__/storybook-stories.storyshot b/components/combobox/__docs__/__snapshots__/storybook-stories.storyshot index b2d68d3e48..250fd9caaf 100644 --- a/components/combobox/__docs__/__snapshots__/storybook-stories.storyshot +++ b/components/combobox/__docs__/__snapshots__/storybook-stories.storyshot @@ -20,10 +20,7 @@ exports[`DOM snapshots SLDSCombobox Base 1`] = ` className="slds-combobox_container" >
@@ -228,10 +227,7 @@ exports[`DOM snapshots SLDSCombobox Base Custom Menu Item 1`] = ` className="slds-combobox_container" >
@@ -291,10 +289,7 @@ exports[`DOM snapshots SLDSCombobox Base Custom Menu Item Disabled 1`] = ` className="slds-combobox_container" >
@@ -373,11 +370,8 @@ exports[`DOM snapshots SLDSCombobox Base Inherit Menu Width - Right to Left (RTL className="slds-combobox_container" >
@@ -802,10 +798,7 @@ exports[`DOM snapshots SLDSCombobox Base Inherit Menu Width 1`] = ` className="slds-combobox_container" >
@@ -908,10 +903,7 @@ exports[`DOM snapshots SLDSCombobox Base Inline Help 1`] = ` className="slds-combobox_container" >
@@ -1117,10 +1111,7 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled 1`] = ` className="slds-combobox_container" >
@@ -1327,10 +1320,7 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip 1`] = ` className="slds-combobox_container" >
@@ -1537,11 +1529,8 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1` className="slds-combobox_container" >
@@ -2160,10 +2151,7 @@ exports[`DOM snapshots SLDSCombobox Base Menu Separator 1`] = ` className="slds-combobox_container" >
@@ -2223,10 +2213,7 @@ exports[`DOM snapshots SLDSCombobox Base Menu Sub Headers 1`] = ` className="slds-combobox_container" >
@@ -2286,10 +2275,7 @@ exports[`DOM snapshots SLDSCombobox Base Pre-defined Options Only 1`] = ` className="slds-combobox_container" >
@@ -2494,11 +2482,8 @@ exports[`DOM snapshots SLDSCombobox Base With Input 1`] = ` className="slds-combobox_container" >
@@ -2845,10 +2832,7 @@ exports[`DOM snapshots SLDSCombobox Base With Scroll 1`] = ` className="slds-combobox_container" >
@@ -3053,10 +3039,7 @@ exports[`DOM snapshots SLDSCombobox Dialog 1`] = ` className="slds-combobox_container" >
@@ -3340,10 +3323,7 @@ exports[`DOM snapshots SLDSCombobox Inline Multiple Selection Loading 1`] = ` className="slds-combobox_container" >
@@ -3421,10 +3403,7 @@ exports[`DOM snapshots SLDSCombobox Inline Single Entity Selection 1`] = ` className="slds-combobox_container" >
@@ -3480,10 +3461,7 @@ exports[`DOM snapshots SLDSCombobox Inline Single Entity Selection 1`] = ` className="slds-combobox_container" >
@@ -3547,10 +3527,7 @@ exports[`DOM snapshots SLDSCombobox Inline Single Search/Add Entities - Open 1`] className="slds-combobox_container" >
@@ -3943,10 +3922,7 @@ exports[`DOM snapshots SLDSCombobox Inline Single Search/Add Entities 1`] = ` className="slds-combobox_container" >
@@ -4007,10 +3985,7 @@ exports[`DOM snapshots SLDSCombobox Inline Single Selection 1`] = ` className="slds-combobox_container" >
@@ -4071,10 +4048,7 @@ exports[`DOM snapshots SLDSCombobox Inline Single Selection Predefined Options O className="slds-combobox_container" >
@@ -4135,10 +4111,7 @@ exports[`DOM snapshots SLDSCombobox Inline Single Selection With Custom Open Sta className="slds-combobox_container" >
@@ -4199,10 +4174,7 @@ exports[`DOM snapshots SLDSCombobox Input Component as a Prop 1`] = ` className="slds-combobox_container" >
@@ -4407,10 +4381,7 @@ exports[`DOM snapshots SLDSCombobox Readonly Multiple Selection 1`] = ` className="slds-combobox_container" >
@@ -4474,10 +4447,7 @@ exports[`DOM snapshots SLDSCombobox Readonly Single Menu Item Disabled 1`] = ` className="slds-combobox_container" >
@@ -4566,10 +4538,7 @@ exports[`DOM snapshots SLDSCombobox Readonly Single Selection - Right to Left (R className="slds-combobox_container" >
@@ -4635,10 +4606,7 @@ exports[`DOM snapshots SLDSCombobox Readonly Single Selection 1`] = ` className="slds-combobox_container" >
@@ -4703,10 +4673,7 @@ exports[`DOM snapshots SLDSCombobox Readonly Single Selection Custom Menu Item 1 className="slds-combobox_container" >
@@ -4771,10 +4740,7 @@ exports[`DOM snapshots SLDSCombobox Readonly Single Selection Disabled 1`] = ` className="slds-combobox_container" >
@@ -4845,10 +4813,7 @@ exports[`DOM snapshots SLDSCombobox Required Input in Error State 1`] = ` className="slds-combobox_container" >
@@ -4919,11 +4886,8 @@ exports[`DOM snapshots SLDSCombobox Snapshot Base Custom Menu Item Open 1`] = ` className="slds-combobox_container" >
@@ -5210,10 +5176,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Base Label Required 1`] = ` className="slds-combobox_container" >
@@ -5284,11 +5249,8 @@ exports[`DOM snapshots SLDSCombobox Snapshot Base Open 1`] = ` className="slds-combobox_container" >
@@ -5465,11 +5429,8 @@ exports[`DOM snapshots SLDSCombobox Snapshot Base Open Menu Sub Header Separator className="slds-combobox_container" >
@@ -5588,11 +5551,8 @@ exports[`DOM snapshots SLDSCombobox Snapshot Base Open Menu inheritWidthOf prop className="slds-combobox_container" >
@@ -5711,10 +5673,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Base Selected 1`] = ` className="slds-combobox_container" >
@@ -5852,10 +5813,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Dialog Open 1`] = ` className="slds-combobox_container" >
@@ -6363,10 +6321,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Inline Multiple Selection 1`] = ` className="slds-combobox_container" >
@@ -6573,10 +6530,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Inline Multiple Selection Selected
@@ -6654,10 +6610,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Inline Single Entity Selection 1`] className="slds-combobox_container" >
@@ -6709,10 +6664,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Inline Single Entity Selection 1`] className="slds-combobox_container" >
@@ -6776,10 +6730,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Inline Single Search/Add Entities O className="slds-combobox_container" >
@@ -7086,10 +7039,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Inline Single Selection 1`] = ` className="slds-combobox_container" >
@@ -7150,10 +7102,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Inline Single Selection Selected 1` className="slds-combobox_container slds-has-inline-listbox" >
@@ -7243,10 +7194,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Multiple Selection 1`] = ` className="slds-combobox_container" >
@@ -7310,10 +7260,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Multiple Selection Multipl className="slds-combobox_container" >
@@ -7480,10 +7429,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Multiple Selection Single className="slds-combobox_container" >
@@ -7547,10 +7495,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Single Selection 1`] = ` className="slds-combobox_container" >
@@ -7615,10 +7562,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Single Selection Custom Me className="slds-combobox_container" >
@@ -8248,10 +8194,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Single Selection Disabled className="slds-combobox_container" >
@@ -8316,10 +8261,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Single Selection Selected className="slds-combobox_container" >
@@ -8384,10 +8328,7 @@ exports[`DOM snapshots SLDSCombobox Snapshot Readonly Single Selection Selected className="slds-combobox_container" >
diff --git a/components/combobox/__tests__/combobox.browser-test.jsx b/components/combobox/__tests__/combobox.browser-test.jsx index 35caea852e..74fb71d4a9 100644 --- a/components/combobox/__tests__/combobox.browser-test.jsx +++ b/components/combobox/__tests__/combobox.browser-test.jsx @@ -226,15 +226,16 @@ describe('SLDSCombobox', function describeFunction() { destroyMountNode({ wrapper, mountNode }); }); - it('has aria-haspopup, aria-expanded is false when closed, aria-expanded is true when open', function () { + it('has aria-haspopup, role is combobox, aria-expanded is false when closed, aria-expanded is true when open', function () { wrapper = mount(, { attachTo: mountNode }); const nodes = getNodes({ wrapper }); - expect(nodes.combobox).attr('aria-haspopup', 'listbox'); + expect(nodes.input).attr('aria-haspopup', 'listbox'); + expect(nodes.input).attr('role', 'combobox'); // closed - expect(nodes.combobox).attr('aria-expanded', 'false'); + expect(nodes.input).attr('aria-expanded', 'false'); // open nodes.input.simulate('click', {}); - expect(nodes.combobox).attr('aria-expanded', 'true'); + expect(nodes.input).attr('aria-expanded', 'true'); }); it('menu filters to second item, menu listbox menu item 2 aria-selected is true, input activedescendent has item 2 id, after pressing down arrow, enter selects item 2', function () { diff --git a/components/combobox/combobox.jsx b/components/combobox/combobox.jsx index a82c23b14f..5de8d1fbbb 100644 --- a/components/combobox/combobox.jsx +++ b/components/combobox/combobox.jsx @@ -1074,11 +1074,8 @@ class Combobox extends React.Component { }, props.className )} - aria-expanded={this.getIsOpen()} - aria-haspopup="listbox" // eslint-disable-line jsx-a11y/aria-proptypes // used on menu's listbox aria-owns={this.getIsOpen() ? `${this.getId()}-listbox` : undefined} // eslint-disable-line jsx-a11y/aria-proptypes - role="combobox" > @@ -1567,9 +1563,6 @@ class Combobox extends React.Component { }, props.className )} - aria-expanded={this.getIsOpen()} - aria-haspopup="listbox" // eslint-disable-line jsx-a11y/aria-proptypes - role="combobox" > @@ -1679,9 +1674,6 @@ class Combobox extends React.Component { }, props.className )} - aria-expanded={this.getIsOpen()} - aria-haspopup="listbox" // eslint-disable-line jsx-a11y/aria-proptypes - role="combobox" >