refactor(engine-core): replaces vm.context wire connecting/disconnecting #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚠ Performance RegressionBest has detected that there is a Please click here to see more details. Click to view significantly changed benchmarks@lwc/engine-dom
@lwc/engine-server
|
Comment on lines
371
to
373
| const connector = createConnector(vm, fieldNameOrMethod, wireDef); | ||
|
|
||
| wiredConnectors.push(connector); |
There was a problem hiding this comment.
Suggested change
| const connector = createConnector(vm, fieldNameOrMethod, wireDef); | |
| wiredConnectors.push(connector); | |
| wiredConnectors.push(createConnector(vm, fieldNameOrMethod, wireDef)); |
caridy
reviewed
Dec 11, 2020
caridy
reviewed
Dec 11, 2020
|
|
||
| // computeConfigAndUpdate already has boundary protection | ||
| if (hasDynamicParams) { | ||
| Promise.resolve().then(computeConfigAndUpdate); |
There was a problem hiding this comment.
we should probably have this as a utility method somewhere.
caridy
reviewed
Dec 11, 2020
pmdartus
reviewed
Dec 14, 2020
| computeConfigAndUpdate: () => void; | ||
| resetConfigWatcher: () => void; | ||
| } { | ||
| function createConnector(vm: VM, name: string, wireDef: WireDef): WireConnector { |
There was a problem hiding this comment.
The amount of closure passing makes the code hard to read. I would convert the connector, config watcher, and context watcher into 3 different classes and pass the object reference around. This would certainly make the code more readable and reduce the overall memory usage due to the closure creation.
pmdartus
reviewed
Dec 15, 2020
ravijayaramappa
approved these changes
Dec 18, 2020
caridy
reviewed
Jan 5, 2021
| private setNewContext = (newContext: ContextValue) => { | ||
| // eslint-disable-next-line lwc-internal/no-invalid-todo | ||
| // TODO: dev-mode validation of config based on the adapter.contextSchema | ||
| if (this.context !== newContext) { |
There was a problem hiding this comment.
this in an arrow function set into a private field seems like the wrong thing to do.
jodarove
commented
Jan 6, 2021
| } | ||
|
|
||
| computeConfig() { | ||
| return this.configCallback(this.component); |
There was a problem hiding this comment.
this should have boundary protection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR attempts to simplify the logic of how the wiring is done by encapsulating the connect/disconnect logic into the
WireConnectorand all context related logic into theContextWatcherabstractions.Does this PR introduce breaking changes?
No, it does not introduce breaking changes.