From 0df5f6eef32266eba548e8008e64406cf0633c67 Mon Sep 17 00:00:00 2001 From: James Tu Date: Wed, 27 Mar 2024 14:45:00 -0700 Subject: [PATCH 1/2] fix: add signals as dependency --- packages/@lwc/engine-core/package.json | 6 +++--- packages/@lwc/engine-core/src/libs/signal-tracker/index.ts | 2 +- packages/lwc/package.json | 1 + 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/@lwc/engine-core/package.json b/packages/@lwc/engine-core/package.json index aa1320f786..ff7bec9c41 100644 --- a/packages/@lwc/engine-core/package.json +++ b/packages/@lwc/engine-core/package.json @@ -43,10 +43,10 @@ }, "dependencies": { "@lwc/features": "6.3.4", - "@lwc/shared": "6.3.4" + "@lwc/shared": "6.3.4", + "@lwc/signals": "6.3.4" }, "devDependencies": { - "observable-membrane": "2.0.0", - "@lwc/signals": "6.3.4" + "observable-membrane": "2.0.0" } } diff --git a/packages/@lwc/engine-core/src/libs/signal-tracker/index.ts b/packages/@lwc/engine-core/src/libs/signal-tracker/index.ts index 63ef8b058d..4a6d04745b 100644 --- a/packages/@lwc/engine-core/src/libs/signal-tracker/index.ts +++ b/packages/@lwc/engine-core/src/libs/signal-tracker/index.ts @@ -5,8 +5,8 @@ * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT */ import { isFalse, isFunction, isUndefined } from '@lwc/shared'; -import { Signal } from '@lwc/signals'; import { logWarnOnce } from '../../shared/logger'; +import type { Signal } from '@lwc/signals'; /** * This map keeps track of objects to signals. There is an assumption that the signal is strongly referenced diff --git a/packages/lwc/package.json b/packages/lwc/package.json index 2c9176d732..753c847b38 100644 --- a/packages/lwc/package.json +++ b/packages/lwc/package.json @@ -31,6 +31,7 @@ "@lwc/module-resolver": "6.3.4", "@lwc/rollup-plugin": "6.3.4", "@lwc/shared": "6.3.4", + "@lwc/signals": "6.3.4", "@lwc/style-compiler": "6.3.4", "@lwc/synthetic-shadow": "6.3.4", "@lwc/template-compiler": "6.3.4", From c82993a9f44de059ee8858291611f5fa2a4fe9c0 Mon Sep 17 00:00:00 2001 From: James Tu Date: Wed, 27 Mar 2024 14:57:07 -0700 Subject: [PATCH 2/2] chore: remove signals from lwc export --- packages/lwc/package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/lwc/package.json b/packages/lwc/package.json index 753c847b38..2c9176d732 100644 --- a/packages/lwc/package.json +++ b/packages/lwc/package.json @@ -31,7 +31,6 @@ "@lwc/module-resolver": "6.3.4", "@lwc/rollup-plugin": "6.3.4", "@lwc/shared": "6.3.4", - "@lwc/signals": "6.3.4", "@lwc/style-compiler": "6.3.4", "@lwc/synthetic-shadow": "6.3.4", "@lwc/template-compiler": "6.3.4",