Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): composed event whitelist #462

Merged
merged 5 commits into from
Jul 3, 2018

Conversation

davidturissini
Copy link
Contributor

@davidturissini davidturissini commented Jul 2, 2018

Details

Restricting native events with composed: true to spec'd out events: WICG/webcomponents#513 (comment)

Fixes #458

Does this PR introduce a breaking change?

  • Yes
  • No
    change events will no longer pass through the shadow dom.

@davidturissini davidturissini changed the title fix(engine): change event is no longer composed: true fix(engine): composed event whitelist Jul 2, 2018
@davidturissini davidturissini force-pushed the dturissini/composed-change-event branch from 837eeba to 882de83 Compare July 3, 2018 16:58
@ekashida
Copy link
Member

ekashida commented Jul 3, 2018

Nice, you already updated the list of breaking changes!

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 614e8dd | Target commit: e362ff0

lwc-engine-benchmark

table-append-1k metric base(614e8dd) target(e362ff0) trend
benchmark-table/append/1k duration 162.70 (± 5.50 ms) 158.00 (± 5.60 ms) 2.89% 👍
table-clear-1k metric base(614e8dd) target(e362ff0) trend
benchmark-table/clear/1k duration 13.30 (± 0.60 ms) 11.50 (± 0.50 ms) 13.53% 👍
table-create-10k metric base(614e8dd) target(e362ff0) trend
benchmark-table/create/10k duration 931.40 (± 10.30 ms) 909.80 (± 15.10 ms) 2.32% 👍
table-create-1k metric base(614e8dd) target(e362ff0) trend
benchmark-table/create/1k duration 105.70 (± 2.70 ms) 104.60 (± 2.30 ms) 1.04% 👍
table-update-10th-1k metric base(614e8dd) target(e362ff0) trend
benchmark-table/update-10th/1k duration 87.60 (± 4.00 ms) 90.35 (± 5.10 ms) -3.14% 👌
tablecmp-append-1k metric base(614e8dd) target(e362ff0) trend
benchmark-table-component/append/1k duration 233.20 (± 5.20 ms) 234.60 (± 4.70 ms) -0.60% 👌
tablecmp-clear-1k metric base(614e8dd) target(e362ff0) trend
tablecmp-create-10k metric base(614e8dd) target(e362ff0) trend
benchmark-table-component/create/10k duration 1642.00 (± 12.90 ms) 1658.50 (± 11.70 ms) -1.00% 👎
tablecmp-create-1k metric base(614e8dd) target(e362ff0) trend
benchmark-table-component/create/1k duration 179.30 (± 3.90 ms) 174.40 (± 4.50 ms) 2.73% 👍
tablecmp-update-10th-1k metric base(614e8dd) target(e362ff0) trend
benchmark-table-component/update-10th/1k duration 78.75 (± 4.60 ms) 78.90 (± 4.40 ms) -0.19% 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 614e8dd | Target commit: 8077cb0

lwc-engine-benchmark

table-append-1k metric base(614e8dd) target(8077cb0) trend
benchmark-table/append/1k duration 162.70 (± 5.50 ms) 155.50 (± 5.50 ms) 4.43% 👍
table-clear-1k metric base(614e8dd) target(8077cb0) trend
benchmark-table/clear/1k duration 13.30 (± 0.60 ms) 12.40 (± 0.60 ms) 6.77% 👍
table-create-10k metric base(614e8dd) target(8077cb0) trend
benchmark-table/create/10k duration 931.40 (± 10.30 ms) 889.70 (± 11.90 ms) 4.48% 👍
table-create-1k metric base(614e8dd) target(8077cb0) trend
benchmark-table/create/1k duration 105.70 (± 2.70 ms) 103.00 (± 1.50 ms) 2.55% 👍
table-update-10th-1k metric base(614e8dd) target(8077cb0) trend
benchmark-table/update-10th/1k duration 87.60 (± 4.00 ms) 88.80 (± 5.10 ms) -1.37% 👍
tablecmp-append-1k metric base(614e8dd) target(8077cb0) trend
benchmark-table-component/append/1k duration 233.20 (± 5.20 ms) 232.40 (± 3.60 ms) 0.34% 👌
tablecmp-clear-1k metric base(614e8dd) target(8077cb0) trend
tablecmp-create-10k metric base(614e8dd) target(8077cb0) trend
benchmark-table-component/create/10k duration 1642.00 (± 12.90 ms) 1625.50 (± 14.00 ms) 1.00% 👍
tablecmp-create-1k metric base(614e8dd) target(8077cb0) trend
benchmark-table-component/create/1k duration 179.30 (± 3.90 ms) 171.10 (± 3.60 ms) 4.57% 👍
tablecmp-update-10th-1k metric base(614e8dd) target(8077cb0) trend
benchmark-table-component/update-10th/1k duration 78.75 (± 4.60 ms) 76.60 (± 3.50 ms) 2.73% 👌

@davidturissini davidturissini merged commit 3b57eb7 into master Jul 3, 2018
@davidturissini davidturissini deleted the dturissini/composed-change-event branch July 3, 2018 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants