-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm chart and instruction to use #21
Conversation
sloop-helm-charts/README.md
Outdated
@@ -0,0 +1,9 @@ | |||
# Use sloop-helm-charts to deploy your service | |||
1. Build image and tag, and replace the current ones in values.yaml, we are working an image for people to use, it will be release in a few days. | |||
2. Create a namespace in your cluster for sloop to run, for example: `kubectl create namespace sloop ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: * only if you dont already have a namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our current helm chart use namespace is default, if people dont change it, they will use default namespace
sloop-helm-charts/README.md
Outdated
@@ -0,0 +1,9 @@ | |||
# Use sloop-helm-charts to deploy your service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is instructions for folks not using tiller (or Spinnaker)
sloop-helm-charts/README.md
Outdated
4. Write to yamil file: `helm template . --namespace sloop> sloop-test.yaml` | ||
5. Apply the yaml file in your cluster: `kubectl -n sloop apply -f sloop-test.yaml` | ||
6. Check if the service is running: kubectl -n sloop get pods | ||
7. Once the pod is running, you can use it by: `kc-aws port-forward -n sloop statefulset/sloop 8080 8000` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is very rare that folks are running fully locked down clusters, and those folks would already know how to port forward. At minimum preface this.
Dont think we need |
Should we just name the folder |
sloop-helm-charts/Chart.yaml
Outdated
@@ -0,0 +1,5 @@ | |||
apiVersion: v1 | |||
appVersion: "1.0" | |||
description: A Helm chart for Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably would want to update this and provide more description.
- metadata: | ||
name: sloop-data | ||
spec: | ||
accessModes: [ "ReadWriteOnce" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to see this come from values.yaml
.
- name: sloop-port | ||
port: 80 | ||
protocol: TCP | ||
targetPort: 8080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to see this come from values.yaml
since its a port number that is used multiple times.
sloop-helm-charts/Chart.yaml
Outdated
@@ -0,0 +1,5 @@ | |||
apiVersion: v1 | |||
appVersion: "1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, what is appVersion vs version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appVersion: The version of the app that this contains (optional). This needn't be SemVer.
https://github.com/helm/helm/blob/master/docs/charts.md#the-appversion-field
This is to fix issue #19