Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 160 #173

Merged
merged 3 commits into from Nov 13, 2019
Merged

Issue 160 #173

merged 3 commits into from Nov 13, 2019

Conversation

@miggs125
Copy link
Contributor

miggs125 commented Oct 5, 2019

fixes #160

I have added an additional CookieStore option named allowSpecialUseDomain to allow for special-use domains such as '.local'. This is useful for testing purposes, '.local' is a commonly used suffix in testing environments.The const array in permuteDomain includes only .local because that is what I mentioned in the original issue. However, I could add the rest if needed.

Here are some more links regarding special-use domains
https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains#Special-Use_Domains
https://tools.ietf.org/html/rfc6761
passed all tests. Ran tests with npm run test
Updated the README to reflect changes made

miggs125 added 3 commits Oct 5, 2019
    this was added because .local domains are commonly used for testing
    purposes inside internal/local networks.
    added allowSpecialUseDomain to parameters so that it can be passed to
    permuteDomain, line 103
@salesforce-cla salesforce-cla bot added the cla:missing label Oct 5, 2019
@salesforce-cla

This comment has been minimized.

Copy link

salesforce-cla bot commented Oct 5, 2019

Thanks for the contribution! Before we can merge this, we need @miggs125 to sign the Salesforce.com Contributor License Agreement.

@salesforce-cla salesforce-cla bot added cla:signed and removed cla:missing labels Oct 5, 2019
@medelibero-sfdc medelibero-sfdc self-requested a review Nov 11, 2019
@medelibero-sfdc medelibero-sfdc merged commit 9cb6662 into salesforce:master Nov 13, 2019
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/snyk - package.json (salesforce) No manifest changes detected
salesforce-cla All contributors have signed the CLA
Details
security/snyk - package.json (salesforce) No manifest changes detected
@medelibero-sfdc

This comment has been minimized.

Copy link
Contributor

medelibero-sfdc commented Nov 13, 2019

LGTM - Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.