Constrain spaces before = to 256 #97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: https://www.versioneye.com/Node.JS/tough-cookie/2.3.2; salesforce/tough-cookie#97; salesforce/tough-cookie#92. (A large cookie could cause a slowdown.) This is not really necessary since fresh installs or installs using package-lock.json already get the 2.3.3 version, but we might as well.
Umm... one question... though late. Most browsers truncate cookies beyond a length of 4096 bytes. Why not put that restriction instead of this?
We use tough-cookie inside Postman App and the edge-case dev usage of cookie data is wide-ranging. A more widely acceptable limitation is total cookie length.
P.S., it makes me happy to hear that you're using it in Postman App. I love hearing how folks are using tough-cookie (a nice change from the stream of bugs/changes/etc.). So, thank you :)