From 0ab922a96cab70f64bdc5e4d104b007a34def1b0 Mon Sep 17 00:00:00 2001 From: mshanemc Date: Wed, 2 Jun 2021 16:26:23 -0500 Subject: [PATCH 1/2] fix: use most recent alias --- src/shared/utils.ts | 3 ++- test/shared/utils.test.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/shared/utils.ts b/src/shared/utils.ts index 23bc3f50..4336ee2e 100644 --- a/src/shared/utils.ts +++ b/src/shared/utils.ts @@ -11,7 +11,8 @@ import * as open from 'open'; export const getAliasByUsername = async (username: string): Promise => { const alias = await Aliases.create(Aliases.getDefaultOptions()); const keys = alias.getKeysByValue(username); - return keys?.length ? keys[0] : undefined; + // use the most recently added alias for that username + return keys?.length ? keys[keys.length - 1] : undefined; }; export const openUrl = async (url: string): Promise => { diff --git a/test/shared/utils.test.ts b/test/shared/utils.test.ts index d30d53da..e7d5b5a6 100644 --- a/test/shared/utils.test.ts +++ b/test/shared/utils.test.ts @@ -28,7 +28,7 @@ describe('getAliasByUsername', () => { }); it('returns first alias for a username that has multiple aliases', async () => { - expect(await getAliasByUsername('username2')).to.equal('alias2'); + expect(await getAliasByUsername('username2')).to.equal('alias2b'); }); it('returns undefined when no matching username is found', async () => { From 5ef83ccbf4411718861e6d5f4d6f9791bb02f491 Mon Sep 17 00:00:00 2001 From: mshanemc Date: Thu, 3 Jun 2021 08:15:51 -0500 Subject: [PATCH 2/2] style: accurate name for multiple alias test --- test/shared/utils.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/shared/utils.test.ts b/test/shared/utils.test.ts index e7d5b5a6..48ec6281 100644 --- a/test/shared/utils.test.ts +++ b/test/shared/utils.test.ts @@ -27,7 +27,7 @@ describe('getAliasByUsername', () => { expect(await getAliasByUsername('username1')).to.equal('alias1'); }); - it('returns first alias for a username that has multiple aliases', async () => { + it('returns most recent alias for a username that has multiple aliases', async () => { expect(await getAliasByUsername('username2')).to.equal('alias2b'); });