fix: add mdapi:deploy:cancel command, refactor base classes to support MDAPI and SOURCE stash keys

[WillieRuemmele]

What does this PR do?

moves mdapi:deploy:cancel command and messages
extends plugin-source base classes correctly
updates base classes to support MDAPI_DEPLOY stash key
adds UTs
adds NUTs

source:deploy:cancel,source:deploy:report, mdapi:deploy:cancel all validate the passed in deploy ID parameter
fixes issue when stash is missing a requested key/value

What issues does this PR fix or reference?

@W-9603715@

[mshanemc]

approved with non-blocking suggestions/questions

[mshanemc]

+1

[mshanemc]

is the idea that the mdapi:deploy command will just have it's own flag that's set to zero (that is, just not using the default)?

[WillieRuemmele]

hmmm good point. for mdapi:deploy:cancel in toolbelt it was using the source:deploy default, it seemed weird to have this variable mention SRC when it's now used in both source and mdapi

very open to reverting this back

[mshanemc]

I think it's good since 33 seems to be most everywhere. Just making sure we weren't gonna come back and put a DEFAULT_MDAPI_WAIT_MINUTES or whatever.

[mshanemc]

+1 for the TODO

[mshanemc]

QA notes:

👎🏻 run --help
There's some odd indentation stuff happening. Compare ./bin/run force:mdapi:deploy:cancel --help to ./bin/run force:source:deploy:cancel --help to see the difference

✅ run without a username (good error)
❌ run without a jobid on an org with no stash yields

ERROR running force:mdapi:deploy:cancel:  Cannot read property 'jobid' of undefined

vs toolbelt

ERROR running force:mdapi:deploy:cancel:  A required parameter [jobid] is missing.

👎🏻 ask to cancel a jobId that doesn't exist. Toolbelt is similarly bad.

ERROR running force:mdapi:deploy:cancel:  INVALID_CROSS_REFERENCE_KEY: invalid cross reference id

✅ cancel a job that already succeeded fails with ERROR running force:mdapi:deploy:cancel: The cancel command failed due to: INVALID_ID_FIELD: Deployment already completed

👎🏻 cancel a jobid that is a CustomObject's id fails with ERROR running force:mdapi:deploy:cancel: The cancel command failed due to: UNKNOWN_EXCEPTION: unexpected metadata [yet we know what the prefix has to be 0Af and could validate the ID is of the correct type before even making an API call)

👎🏻 cancel a job, then cancel it again fails with ERROR running force:mdapi:deploy:cancel: INVALID_ID_FIELD: Deployment already completed (kinda true, I guess?)

• 👎🏻 json output of toolbelt had a nicer named error

     "name": "CancelFailed",
     "message": "The cancel command failed due to: INVALID_ID_FIELD: Deployment already completed",

that's changed to

      "name": "sf:INVALID_ID_FIELD",
      "message": "INVALID_ID_FIELD: Deployment already completed",     

✅ delete stash.json and then run without an id fails with ERROR running force:mdapi:deploy:cancel: No deploy ID was provided or found in deploy history
✅ json output of successful cancel matches between toolbelt and plugin