fix: add purgeondelete flag to deploy #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
requested review from
cristiand391,
jshackell-sfdc,
maggiben,
mshanemc and
shetzel
WillieRuemmele
commented
Jan 19, 2022
| "predestructivechanges": "file path for a manifest (destructiveChangesPre.xml) of components to delete before the deploy", | ||
| "postdestructivechanges": "file path for a manifest (destructiveChangesPost.xml) of components to delete after the deploy" | ||
| "postdestructivechanges": "file path for a manifest (destructiveChangesPost.xml) of components to delete after the deploy", | ||
| "purgeOnDelete": "the deleted components in the destructiveChanges.xml manifest file aren't stored in the Recycle Bin. Instead, they become immediately eligible for deletion." |
Contributor
Author
There was a problem hiding this comment.
@jshackell-sfdc I took this description right from here but let me know if it should be different
Contributor
There was a problem hiding this comment.
I reworked it a bit, see below.
| "predestructivechanges": "file path for a manifest (destructiveChangesPre.xml) of components to delete before the deploy", | ||
| "postdestructivechanges": "file path for a manifest (destructiveChangesPost.xml) of components to delete after the deploy" | ||
| "postdestructivechanges": "file path for a manifest (destructiveChangesPost.xml) of components to delete after the deploy", | ||
| "purgeOnDelete": "the deleted components in the destructiveChanges.xml manifest file aren't stored in the Recycle Bin. Instead, they become immediately eligible for deletion." |
Contributor
There was a problem hiding this comment.
Suggested change
| "purgeOnDelete": "the deleted components in the destructiveChanges.xml manifest file aren't stored in the Recycle Bin. Instead, they become immediately eligible for deletion." | |
| "purgeOnDelete": "specify that deleted components in the destructive changes manifest file are immediately eligible for deletion rather than being stored in the Recycle Bin" |
Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com>
jshackell-sfdc
requested changes
Jan 19, 2022
Contributor
jshackell-sfdc
left a comment
jshackell-sfdc
left a comment
There was a problem hiding this comment.
edited the flag description, let me know if i mistakenly changed the meaning!
mshanemc
approved these changes
Jan 20, 2022
cristiand391
approved these changes
Jan 24, 2022
shetzel
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds
purgeondeleteto*:deploywhich will empty the recycle bin when an object is deletedI'm not sure how to verify this in Lightning
destructiveChangesPost.xml)package.xml)sfdx force:source:deploy -x package.xml --postdestructivechanges destructiveChangesPost.xmlDeleted Objects(1)at the bottom of the listsfdx force:source:deploy -x package.xml --postdestructivechanges destructiveChangesPost.xml --purgeondeleteDeleted ObjectsWhat issues does this PR fix or reference?
@W-4649658@