Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed import statements not being transformed #19

Merged
merged 1 commit into from Feb 10, 2020
Merged

Conversation

@fetimo
Copy link
Contributor

fetimo commented Feb 10, 2020

Description

Since 1.1.0 we haven't been exporting to CJS which the ui library requires to run properly. I think it was due to a Babel upgrade around that time. This adds @babel/plugin-transform-modules-commonjs to transform them.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated the changelog
  • My branch has no conflicts with the branch I want to merge into
@fetimo fetimo requested a review from SaloCreative Feb 10, 2020
@SaloCreative SaloCreative merged commit e22833c into master Feb 10, 2020
1 check passed
1 check passed
salo-core-icons/development Build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.